fix: relax response-DTO models from extra='forbid' to extra='ignore'#46
Merged
Merged
Conversation
Response-shape classes (*Dto, *Response) now use extra='ignore' so new fields added to the API don't break surfaces built against an older spec. Request classes keep extra='forbid' for validation. Implements Postel's Law: strict on requests, tolerant on responses. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
*Dto,*Response) now useextra='ignore'instead ofextra='forbid'so new fields added to the API don't break surfaces built against an older spec.extra='forbid'for validation of user input.Motivation
Adding
enabledtoAlertChannelDtoin the API broke all surfaces because Pydantic models withextra='forbid'reject unknown response fields. This is a systemic fix — every future API field addition will now be backward-compatible for all published surface versions.Test plan
inject_strict_config.pycorrectly classifies DTOs vs RequestsAlertChannelDtogetsextra='ignore',CreateAlertChannelRequestkeepsextra='forbid'Made with Cursor