Skip to content

Incremental SMT2: Remove unnecessary #if 0 for floating-point modulo#9027

Merged
kroening merged 1 commit into
diffblue:developfrom
tautschnig:incr-smt-remove-dead-if0
Jun 3, 2026
Merged

Incremental SMT2: Remove unnecessary #if 0 for floating-point modulo#9027
kroening merged 1 commit into
diffblue:developfrom
tautschnig:incr-smt-remove-dead-if0

Conversation

@tautschnig
Copy link
Copy Markdown
Collaborator

All floating-point operations are handled via an earlier branch, even if changed to #if 1 it would remain dead code. #8922 added full floating-point support to the incremental SMT2 back-end.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

All floating-point operations are handled via an earlier branch, even if
changed to `#if 1` it would remain dead code. diffblue#8922 added full
floating-point support to the incremental SMT2 back-end.
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.60%. Comparing base (01ebe42) to head (9e494db).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #9027   +/-   ##
========================================
  Coverage    80.59%   80.60%           
========================================
  Files         1711     1711           
  Lines       189454   189454           
  Branches        73       73           
========================================
+ Hits        152697   152700    +3     
+ Misses       36757    36754    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kroening kroening merged commit 5bc79af into diffblue:develop Jun 3, 2026
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants