Skip to content

Add test vectors for mocked classes#76

Open
OR13 wants to merge 6 commits into
digitalbazaar:mainfrom
transmute-industries:feat/test-vectors
Open

Add test vectors for mocked classes#76
OR13 wants to merge 6 commits into
digitalbazaar:mainfrom
transmute-industries:feat/test-vectors

Conversation

@OR13

@OR13 OR13 commented Oct 16, 2020

Copy link
Copy Markdown

In order to establish test vectors for EDVs we need to extract the string values from the mocked classes, and the expected inputs and outputs associated with hmac and ed25519 sign.

This PR adds JSON files for establishing conformance for mocked classes.

@OR13

OR13 commented Oct 16, 2020

Copy link
Copy Markdown
Author

ping @dlongley @msporny @dmitrizagidulin trying to add test vector generation code to this code base, before attempting to reimplement the client for the SDS.

@OR13

OR13 commented Oct 16, 2020

Copy link
Copy Markdown
Author

partially blocked by digitalbazaar/http-signature-zcap-invoke#11

@dlongley

Copy link
Copy Markdown
Member

@OR13, ack, we're looking into the partial blocker.

@OR13

OR13 commented Oct 21, 2020

Copy link
Copy Markdown
Author

This can be merged, and I can circle back to add better tests for http invocation if thats desirable.

@dlongley

Copy link
Copy Markdown
Member

@aljones15 -- we need to run these test vectors against our current implementations to see if everything checks out. If it does, we can merge this -- if not, we should see what needs to be tweaked (one way or the other). I don't want to push test vectors forward that cause more people to have bugs/differences that shouldn't be there.

Comment thread tests/70-HttpSignatureCapabilityInvocation.spec.js Outdated
Co-authored-by: Dave Longley <dlongley@digitalbazaar.com>
@OR13

OR13 commented Dec 28, 2020

Copy link
Copy Markdown
Author

any movement on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants