Skip to content

[FIX] fix compression defaults#43

Merged
36000 merged 1 commit into
dipy:masterfrom
36000:fix
Jun 3, 2026
Merged

[FIX] fix compression defaults#43
36000 merged 1 commit into
dipy:masterfrom
36000:fix

Conversation

@36000
Copy link
Copy Markdown
Collaborator

@36000 36000 commented Jun 3, 2026

No description provided.

Copilot AI review requested due to automatic review settings June 3, 2026 20:24
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the default streamline compression settings in GenericTracker so they match the documented and public set_compression_parameters(...) defaults, ensuring consistent behavior when callers don’t explicitly set compression parameters.

Changes:

  • Change the default position dtype fallback from np.float16 to np.float32.
  • Change the default max_segment_length fallback from np.inf to 10.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@36000 36000 merged commit b1a7812 into dipy:master Jun 3, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants