Fix StringIndexOutOfBoundsException on repeated pause (#638)#642
Open
aki1770-del wants to merge 1 commit into
Open
Fix StringIndexOutOfBoundsException on repeated pause (#638)#642aki1770-del wants to merge 1 commit into
aki1770-del wants to merge 1 commit into
Conversation
lastProgress is set by onRangeStart() relative to the current utterance and is not consumed when pause trims pauseText. A repeated pause before the next onRangeStart (e.g. rapid pause taps) re-applies the stale index to the already-shortened text and crashes with StringIndexOutOfBoundsException. Coerce the index into bounds, treat fully-spoken as nothing-left-to-resume, and reset lastProgress once it has been consumed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #638.
lastProgressis relative to the current utterance but is not reset whenpausetrimspauseText— a second pause arriving before the nextonRangeStartapplies the stale index to the already-shortened string, throwingStringIndexOutOfBoundsException(reproducible: speak, wait past the halfway point, then pause twice quickly).Change: coerce the index into the valid range, treat an at/past-end index as fully-spoken (clear pause state), and reset
lastProgressafter consuming it — consistent with the existing resets instopandonDone.Verification (build-verified locally before submitting; Android 11 / API 30 emulator, Google TTS):
StringIndexOutOfBoundsException: length=44; index=119atFlutterTtsPlugin.kt:363.