Skip to content

Replace build-time code generation with AssemblyInformationalVersion for version info#330

Merged
agocke merged 1 commit into
dn-vm:mainfrom
curllog:main
Jun 16, 2026
Merged

Replace build-time code generation with AssemblyInformationalVersion for version info#330
agocke merged 1 commit into
dn-vm:mainfrom
curllog:main

Conversation

@curllog

@curllog curllog commented Mar 20, 2026

Copy link
Copy Markdown
Contributor

Removed the MSBuild EmbedVersionInfo target that generated GitVersionInformation.g.cs at build time, which caused IDE errors (red squiggles)

  • Set in Directory.Build.props to embed version and git SHA via the built-in AssemblyInformationalVersionAttribute
  • Updated Program.cs to read version info from the assembly attribute instead of the generated class

@agocke agocke left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@agocke agocke closed this Jun 16, 2026
@agocke agocke reopened this Jun 16, 2026
@agocke agocke enabled auto-merge (squash) June 16, 2026 02:18
@agocke agocke merged commit 8351479 into dn-vm:main Jun 16, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants