Speed up reload and resume#238
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reloading and resuming long sessions should feel much snappier now.
This PR fixes the two slow paths that dominated profiling:
get_messagesRPC responses are accumulated linearly instead of repeatedly copying the growing partial JSON lineIt keeps one small render-path improvement: full history replay temporarily raises the GC threshold so GC does not interrupt the visible rebuild. The render benchmark is roughly flat; the big wins come from RPC framing and session metadata scanning.
It also adds a deterministic synthetic reload/resume benchmark suite with GUI/xvfb as the primary lane and batch as the CI-friendly smoke lane.
Benchmark results
Synthetic fixtures, GUI via xvfb, 3 repetitions per scenario, diagnostic timing advice disabled:
The committed benchmark can be run with:
Validation
make check