feat: improve indexing and embedded search#2734
Conversation
|
@sy-records is attempting to deploy a commit to the Docsify Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
paulhibbitts
left a comment
There was a problem hiding this comment.
Thanks for taking on this PR @sy-records ! I had a difficult time in trying to replicate search failures in codesandbox with a broken page so I created two GitHub Pages test repos based on the example provided by @kokovtsev after verifying locally.
Search index test (RC) - search for 'ipsum' fails:
https://github.com/paulhibbitts/docsify-v5-search-index-RC
https://paulhibbitts.github.io/docsify-v5-search-index-RC/#/
Search index test (PR preview build) - search for 'ipsum' succeeds:
https://github.com/paulhibbitts/docsify-v5-search-index-PR
https://paulhibbitts.github.io/docsify-v5-search-index-PR/#/
Hope you can also confirm these tests.
|
That's right. |
There was a problem hiding this comment.
Thanks for addressing the embedded content search aspect in this PR as well @sy-records !
I've updated my two previous test repos.
Search index test (RC) - search for 'embedded' fails (removing the previous broken link test so search works again):
https://github.com/paulhibbitts/docsify-v5-search-index-RC
https://paulhibbitts.github.io/docsify-v5-search-index-RC/#/
Search index test (PR preview build) - search for 'embedded' succeeds:
https://github.com/paulhibbitts/docsify-v5-search-index-PR
https://paulhibbitts.github.io/docsify-v5-search-index-PR/#/
With the latest PR test build, both the broken link and embedded content search issues look fixed 👍🏼
Summary
Related issue, if any:
Close #2674
Close #2689, Thanks @Bowl42
Close #2675, Thanks @kokovtsev
Close #1277
What kind of change does this PR introduce?
For any code change,
Does this PR introduce a breaking change?
Tested in the following browsers: