Skip to content

.MD files, json-ld updated with faq also twig files updated with faq#17

Merged
alexmerlin merged 5 commits into
developfrom
stefan-dev
Jul 22, 2026
Merged

.MD files, json-ld updated with faq also twig files updated with faq#17
alexmerlin merged 5 commits into
developfrom
stefan-dev

Conversation

@OStefan2001

Copy link
Copy Markdown
Collaborator

No description provided.

@alexmerlin alexmerlin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The markdown files contain hardcoded URLs, example:

canonical_url: "https://new.dotkernel.com/android/multiple-broadcast-receivers-in-the-same-app-for-the-same-action/"

Those URLs must be relative to the domain they are served from.
Else, when we switch to the main domain (new.dotkernel.com -> dotkernel.com), those URLs will be invalid.

@OStefan2001
OStefan2001 requested a review from alexmerlin July 22, 2026 06:30

@alexmerlin alexmerlin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Mind the "one sentence per row" rule.
  2. There's no way of having those URLs relative to the domain they are served from?

@OStefan2001

Copy link
Copy Markdown
Collaborator Author

I will search and find a way to make URLs relative to domains

@alexmerlin
alexmerlin merged commit ca4e97c into develop Jul 22, 2026
14 checks passed
@alexmerlin
alexmerlin deleted the stefan-dev branch July 22, 2026 08:08
@codecov

codecov Bot commented Jul 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 22.46%. Comparing base (82cada0) to head (3903c81).
⚠️ Report is 12 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop      #17   +/-   ##
==========================================
  Coverage      22.46%   22.46%           
  Complexity       178      178           
==========================================
  Files             43       43           
  Lines            819      819           
==========================================
  Hits             184      184           
  Misses           635      635           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants