Skip to content

[Mono.Android] Fix JNI local reference disposal with ownership flags #12380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonathanpeppers merged 1 commit into from
Aug 14, 2026
+15 −1
Merged

[Mono.Android] Fix JNI local reference disposal with ownership flags #12380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Mono.Android/Android.Runtime/JNIEnv.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,7 @@ public static void EnsureLocalCapacity (int capacity)

internal static void DeleteRef (IntPtr handle, JniHandleOwnership transfer)
{
switch (transfer) {
switch (transfer & (JniHandleOwnership.TransferLocalRef | JniHandleOwnership.TransferGlobalRef)) {
case JniHandleOwnership.DoNotTransfer:
break;
case JniHandleOwnership.TransferLocalRef:
Expand Down
14 changes: 14 additions & 0 deletions tests/Mono.Android-Tests/Mono.Android-Tests/Java.Interop/JavaConvertTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,20 @@ public void NullStringMarshalsAsIntPtrZero ()
Assert.AreEqual (null, list [0]);
}

[Test]
public void DeleteLocalRefWithDoNotRegister ()
{
int initialLocalReferenceCount = Java.Interop.Runtime.LocalReferenceCount;

using (var value = new Java.Lang.String (
JNIEnv.NewString ("value"),
JniHandleOwnership.TransferLocalRef | JniHandleOwnership.DoNotRegister)) {
Comment thread
jonathanpeppers marked this conversation as resolved.
Assert.AreEqual ("value", value.ToString ());
}

Assert.AreEqual (initialLocalReferenceCount, Java.Interop.Runtime.LocalReferenceCount);
}

[Test]
public void MarshalInt23Array ()
{
Expand Down
Loading