Clarify OutputCache intent and limitations for classic ASP.Net.#54828
Open
StephenMolloy wants to merge 1 commit into
Open
Clarify OutputCache intent and limitations for classic ASP.Net.#54828StephenMolloy wants to merge 1 commit into
StephenMolloy wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request clarifies how ASP.NET output caching variation works in .NET Framework scenarios, and adds consistent guidance that cache variation is for performance—not for isolating sensitive or personalized responses.
Changes:
- Expanded output caching explanation, including how
VaryBy*settings influence cached representations. - Added consistent IMPORTANT warnings across relevant docs that cache variation doesn’t enforce security or isolation boundaries.
- Updated the WCF + ASP.NET output caching integration sample documentation to include the same guidance.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs/framework/wcf/samples/aspnet-caching-integration.md | Adds an IMPORTANT warning about not using cache variation to isolate sensitive or personalized content. |
| docs/framework/wcf/feature-details/caching-support-for-wcf-web-http-services.md | Adds the same IMPORTANT warning; also contains a minor attribute-name inconsistency called out in review comments. |
| docs/framework/performance/caching-in-net-framework-applications.md | Expands the “Output Caching” section with explanation of alternate representations and adds an IMPORTANT warning about isolation limitations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the documentation for output caching in .NET Framework applications by clarifying how cache variation settings like
VaryByParamandVaryByHeaderwork, and by adding important guidance about not relying on cache variation for isolating sensitive content. The updates emphasize that output caching is a performance optimization and that isolation for personalized or sensitive responses must be enforced separately.Clarification and guidance on output caching:
docs/framework/performance/caching-in-net-framework-applications.md: Expanded the explanation of output caching, detailing howVaryBysettings (such asVaryByParam,VaryByHeader,VaryByCustom, andVaryByContentEncoding) determine which representations are cached, and added a warning not to use cache variation for isolating sensitive or personalized content.docs/framework/wcf/feature-details/caching-support-for-wcf-web-http-services.md: Added a warning that thevaryByParamsetting should not be used to isolate sensitive or personalized responses, and that required isolation should be enforced independently of cache configuration.docs/framework/wcf/samples/aspnet-caching-integration.md: Added a similar warning regarding the use ofvaryByParamandvaryByHeaderin output caching, emphasizing that they are for performance optimization and not for isolating classes of content.## SummaryInternal previews