Remove the dead ImplicitYield language-feature flag - #20225
Conversation
LanguageFeature.ImplicitYield is permanently enabled for every accepted langversion (min --langversion is 8.0), so the flag guard is always true. Keep only the enabled paths and delete the dead legacy branches: - CheckExpressionsOps.fs: collapse YieldFree to its enabled body and drop the now-dead cenv parameter from YieldFree, IsSimpleSemicolonSequenceElement, TryGetSimpleSemicolonSequenceOfComprehension and (|SimpleSemicolonSequence|_|). - CheckSequenceExpressions.fs: drop the constant conjunct in enableImplicitYield, delete the dead SynExpr.Paren guard arm, and delete the dead validateObjectSequenceOrRecordExpression block. - CheckArrayOrListComputedExpressions.fs: collapse the implicitYieldEnabled block and its nested match to the single reachable arm. - CheckComputationExpressions.fs: drop the constant conjunct in enableImplicitYield (field and its branches retained) and update the YieldFree call. The LanguageFeature.ImplicitYield definition is intentionally left in place; a later change removes it. No behavioural change. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The LanguageFeature.ImplicitYield flag shipped in F# 4.7 and is permanently enabled (minimum accepted --langversion is 8.0), so it is dead configuration. All enforcement sites were already collapsed to the always-on path, leaving the flag unreferenced. Delete the ImplicitYield union case (both .fs and .fsi), its features-map entry, its GetFeatureString arm, and the featureImplicitYield resource string. The xlf localization files were regenerated via /t:UpdateXlf. The SynExpr.SequentialOrImplicitYield syntax node and related implementation are unaffected; only the feature flag is removed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
❗ Release notes requiredYou can open this PR in browser to add release notes: open in github.dev Caution No release notes found for the changed paths (see table below). Please make sure to add an entry with an informative description of the change as well as link to this pull request, issue and language suggestion if applicable. Release notes for this repository are based on Keep A Changelog format. The following format is recommended for this repository: `* . (PR #XXXXX)`
If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.
|
github-actions
Bot
added
the
AI-Tooling-Check-Scanned-Clean
|
Duplicate of #20230 (Remove always-on ImplicitYield language feature flag), which touches the identical 20 files, is green across all 48 checks, MERGEABLE, labelled NO_RELEASE_NOTES, and has auto-merge armed. This earlier attempt is CONFLICTING with a red check_release_notes and is superseded. Closing in favor of #20230. |
1 participant
LanguageFeature.ImplicitYieldshipped in F# 4.7 and is permanently enabled for every accepted--langversion(the minimum accepted version is 8.0), so its guards were always true. The dead legacy branches behind the flag are collapsed to the always-on path and the flag itself is removed. No behavioural change.