Skip to content

Remove always-on ImplicitYield language feature flag - #20239

Closed
T-Gro wants to merge 1 commit into
dotnet:mainfrom
T-Gro:copilot/remove-implicityield-flag
Closed

Remove always-on ImplicitYield language feature flag#20239
T-Gro wants to merge 1 commit into
dotnet:mainfrom
T-Gro:copilot/remove-implicityield-flag

Conversation

@T-Gro

@T-Gro T-Gro commented Aug 10, 2026

Copy link
Copy Markdown
Member

Fixes #20143

LanguageFeature.ImplicitYield has been on for every accepted --langversion since F# 4.7, so its feature flag could never be switched off. Removed the flag and every guard, collapsing the code to the always-enabled path. --disableLanguageFeature:ImplicitYield is no longer a recognised feature name.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

❗ Release notes required

You can open this PR in browser to add release notes: open in github.dev

@T-Gro,

Caution

No release notes found for the changed paths (see table below).

Please make sure to add an entry with an informative description of the change as well as link to this pull request, issue and language suggestion if applicable. Release notes for this repository are based on Keep A Changelog format.

The following format is recommended for this repository:

`* . (PR #XXXXX)`

See examples in the files, listed in the table below or in th full documentation at https://fsharp.github.io/fsharp-compiler-docs/release-notes/About.html.

If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

Change path Release notes path Description
`src/Compiler` docs/release-notes/.FSharp.Compiler.Service/11.0.100.md No release notes found or release notes format is not correct
`src/Compiler/Facilities/LanguageFeatures.fsi` docs/release-notes/.Language/preview.md No release notes found or release notes format is not correct

@github-actions github-actions Bot added the AI-Tooling-Check-Scanned-Clean Tooling check: diff analyzed, no interesting infrastructure files label Aug 10, 2026
@T-Gro

T-Gro commented Aug 10, 2026

Copy link
Copy Markdown
Member Author

Closing as a duplicate of #20230 (same ImplicitYield flag removal). #20230 is the consolidated PR: green CI, NO_RELEASE_NOTES, reviewer requested, auto-merge armed. This branch's more-aggressive deletion also trips the FsToolkit.ErrorHandling regression test, so consolidating on #20230.

@T-Gro T-Gro closed this Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI-Tooling-Check-Scanned-Clean Tooling check: diff analyzed, no interesting infrastructure files

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Remove always-on language feature flag: ImplicitYield

1 participant