Skip to content

Clean up unused parameter and stray escape in upload template#5242

Merged
LoopedBard3 merged 1 commit into
dotnet:mainfrom
LoopedBard3:loopedbard3/cleanup-upload-template
Jun 12, 2026
Merged

Clean up unused parameter and stray escape in upload template#5242
LoopedBard3 merged 1 commit into
dotnet:mainfrom
LoopedBard3:loopedbard3/cleanup-upload-template

Conversation

@LoopedBard3

Copy link
Copy Markdown
Member

What

Two small unrelated cleanups in the existing BCS upload pipeline templates. No behavioral change.

1. eng/pipelines/templates/upload-build-artifacts-job.yml

Drop the trailing backslash in the per-artifact job displayName:

-    displayName: 'Upload Build Artifact ${{ artifact.artifactName }}\'
+    displayName: 'Upload Build Artifact ${{ artifact.artifactName }}'

YAML single-quoted strings treat \ as a literal character (the only escape inside a single-quoted string is '' for a single quote). With the current \', the AzDO Web UI literally renders the job name as Upload Build Artifact <name>\. Cosmetic only — the job still runs.

2. eng/pipelines/upload-build-artifacts-jobs.yml

Remove the unused mauiFramework template parameter:

 parameters:
   runtimeRepoAlias: runtime
   performanceRepoAlias: self
   buildType: []
-  mauiFramework: ''

The parameter is declared on the dispatcher but never referenced in the dispatcher body, and no current caller passes it to this template. dotnet/runtime's perf-build.yml passes mauiFramework only to the sibling runtime-perf-build-jobs.yml template (used by the Build stage), not to upload-build-artifacts-jobs.yml (used by the UploadArtifacts stage). Dropping it removes a confusing dead parameter that suggests upload behavior depends on the MAUI framework version (it doesn't).

Why

Both items surfaced during code review of #5241 (the dispatcher generalization for multi-tenant uploads). Splitting them into this small, easily reviewed PR keeps #5241 focused on the generalization story.

Intentionally NOT removed

The runtimeRepoAlias parameter on upload-build-artifacts-jobs.yml is also unused in the dispatcher body — but dotnet/runtime's perf-build.yml does explicitly pass runtimeRepoAlias: self to this template. Removing the parameter here would fail template expansion on the runtime side at the next pipeline run with Unexpected parameter 'runtimeRepoAlias'. Cleaning that up requires a coordinated dotnet/runtime tenant update first, and is left for a follow-up PR.

Validation

  • Both files still parse as valid YAML (yaml.safe_load).
  • git --no-pager grep mauiFramework in dotnet/runtime confirms no UploadArtifacts caller passes the parameter.
  • No callers in dotnet/performance itself (this template has no internal callers — only external tenants like dotnet/runtime).

Two small unrelated cleanups in the BCS upload templates:

1) upload-build-artifacts-job.yml — drop the trailing backslash in the
   'Upload Build Artifact …\\' job displayName. In YAML single-quoted
   strings, backslash is a literal character (only \''\ escapes a
   quote), so this currently renders in the AzDO UI as a stray
   'Upload Build Artifact <name>\\'. Removing it is purely cosmetic.

2) upload-build-artifacts-jobs.yml — remove the unused 'mauiFramework'
   template parameter. It was declared on the dispatcher but never
   referenced in the dispatcher body, and no current caller passes it
   to this template (dotnet/runtime's perf-build.yml passes
   mauiFramework only to runtime-perf-build-jobs.yml, not to
   upload-build-artifacts-jobs.yml). Safe to drop.

Intentionally NOT removed: the 'runtimeRepoAlias' parameter on
upload-build-artifacts-jobs.yml is also unused in the dispatcher body,
but dotnet/runtime's perf-build.yml DOES pass it explicitly. Dropping it
here would fail template expansion on the runtime side with
'Unexpected parameter ''runtimeRepoAlias'''. Cleaning that up requires
a coordinated dotnet/runtime tenant update first and is left for a
follow-up PR.

No behavioral change for any current caller.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings June 11, 2026 23:25

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes two minor cosmetic/template cleanup issues in the BCS upload pipeline YAML to reduce confusion and avoid UI noise, without changing upload behavior.

Changes:

  • Removed an unused mauiFramework parameter from the upload dispatcher template (upload-build-artifacts-jobs.yml).
  • Fixed a stray trailing backslash in the per-artifact upload job displayName so it renders correctly in AzDO UI.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
eng/pipelines/upload-build-artifacts-jobs.yml Drops unused mauiFramework parameter from the upload dispatcher template interface.
eng/pipelines/templates/upload-build-artifacts-job.yml Removes stray \ from the per-artifact job display name to avoid literal backslash rendering.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

runtimeRepoAlias: runtime
performanceRepoAlias: self
buildType: []
mauiFramework: ''

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this not used anywhere, because we got rid of the maui builds?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moreso we are not currently passing it through when we upload the artifacts themselves. This is definitely something we can improve on as I think the builds for mauiFramework are likely not running latest, but we will also need to think about how that affects our storage pathing and flow for the BCS.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is still used in the actual build steps IIRC, this is just the artifact uploading.

@DrewScoggins DrewScoggins left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, barring the one question on removal of mauiFramework.

@LoopedBard3 LoopedBard3 merged commit 2a98435 into dotnet:main Jun 12, 2026
66 of 75 checks passed
@LoopedBard3 LoopedBard3 deleted the loopedbard3/cleanup-upload-template branch June 12, 2026 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants