ICorDebugProcess5.GetTypeFields - add missing MIDL attributes

[MattParkerDev]

GetTypeFields seems to be missing MIDL attributes describing fields's size and length.

[azure-pipelines]

Azure Pipelines:
Successfully started running 3 pipeline(s).
13 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

[dotnet-policy-service]

Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

[Copilot]

Pull request overview

This PR updates the CoreCLR cordebug.idl COM interface definition to add MIDL annotations for ICorDebugProcess5::GetTypeFields, improving parameter direction/array sizing metadata for header/interop generation.

Changes:

• Annotated celt as [in].
• Annotated fields as [out] with size_is(...) / length_is(...) metadata.
• Annotated pceltNeeded as [out].

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

[github-actions]

Workflow state for the Holistic Review Orchestrator.

{
  "version": 5,
  "last_dispatched_commit": "90412d07cdcc39f4518ab88bc8d9203aafebddbe",
  "last_dispatched_base_ref": "main",
  "last_dispatched_base_sha": "3522269feadf7e6d9a5ed422ccd269335ebe62a9",
  "last_reviewed_commit": "90412d07cdcc39f4518ab88bc8d9203aafebddbe",
  "last_reviewed_base_ref": "main",
  "last_reviewed_base_sha": "3522269feadf7e6d9a5ed422ccd269335ebe62a9",
  "last_recorded_worker_run_id": "29688122321",
  "review_attempt_commit": "",
  "review_attempt_base_ref": "",
  "review_attempt_count": 0,
  "max_review_attempts": 5,
  "review_history_format": "holistic-review-disclosure-v1",
  "review_history": [
    {
      "commit": "90412d07cdcc39f4518ab88bc8d9203aafebddbe",
      "review_id": 4730808545
    }
  ]
}

[github-actions]

Holistic Review

Motivation: ICorDebugProcess5::GetTypeFields in cordebug.idl was missing the MIDL directional and array-sizing attributes ([in], [out], size_is, length_is) that every other caller-allocated-buffer method in this interface uses. Without them, the generated proxy/stub marshalling cannot correctly describe the fields buffer, which matters for remote/out-of-process debugging scenarios and tooling that relies on the type library.

Approach: The single-line change annotates the parameters to match the well-established convention already used by sibling APIs such as EnumerateHeap, EnumerateHeapRegions, and GetGCReferences in the same file ([out, size_is(celt), length_is(*pceltNeeded)] on the array, [in] on the count, [out] on the needed-count pointer). This is exactly the pattern at lines 2498, 2556, and 2615, so the fix is consistent and idiomatic.

Summary: This is a correct, minimal, low-risk documentation/marshalling-correctness fix to an IDL declaration. The attributes accurately reflect the method's contract: celt is the input capacity, fields is a caller-allocated output buffer sized by celt with the valid element count given by *pceltNeeded, and pceltNeeded is an output. The change matches surrounding conventions and introduces no behavioral change to existing compiled clients (the underlying C++ signature is unchanged). No concerns; LGTM.

Note

This review was generated by this repository's Holistic Review agentic workflow to complement the built-in Copilot review.

Generated by Holistic Review · 30.5 AIC · ⌖ 9.96 AIC · ⊞ 10K