[wasm] Bump chrome for testing - linux: 150.0.7871.128, windows: 150.0.7871.129, mac: 150.0.7871.129#131023
Conversation
|
Azure Pipelines: Successfully started running 4 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
|
Tagging subscribers to this area: @akoeplinger, @matouskozak, @simonrozsival |
|
Workflow state for the Holistic Review Orchestrator. {
"version": 5,
"last_dispatched_commit": "8222c5c68aa5408059205e0a35b92309bf624cc7",
"last_dispatched_base_ref": "main",
"last_dispatched_base_sha": "13c03a4a9a854291f77636b1e15038e65919e68b",
"last_reviewed_commit": "8222c5c68aa5408059205e0a35b92309bf624cc7",
"last_reviewed_base_ref": "main",
"last_reviewed_base_sha": "13c03a4a9a854291f77636b1e15038e65919e68b",
"last_recorded_worker_run_id": "29689453641",
"review_attempt_commit": "",
"review_attempt_base_ref": "",
"review_attempt_count": 0,
"max_review_attempts": 5,
"review_history_format": "holistic-review-disclosure-v1",
"review_history": [
{
"commit": "8222c5c68aa5408059205e0a35b92309bf624cc7",
"review_id": 4730869529
}
]
} |
There was a problem hiding this comment.
Holistic Review
Motivation: This is an automated dependency bump generated by the WASM Chrome-for-testing update workflow. It advances the pinned Chrome/Chromium versions used by the WebAssembly test infrastructure from the 149.x line to 150.x so that browser tests run against a current Chrome build.
Approach: The change is confined to eng/testing/BrowserVersions.props and updates the Chrome version, revision, and snapshot URL for the macOS and Windows entries, plus the Chrome version for Linux. All three platforms now converge on Chrome revision 1639810 (linux 150.0.7871.128, macOS/windows 150.0.7871.129). The V8 versions (15.1.103) and the Firefox/GeckoDriver revisions are intentionally left unchanged, and the per-platform snapshot base URLs (1639829/1639818/1639827) differ as expected since they point to platform-specific snapshot builds.
Summary: A well-scoped, low-risk, machine-generated version bump. The edits are internally consistent: the previously stale macOS/Windows revision (1625079) is brought in line with Linux, and only version/revision/URL properties change. Correctness ultimately depends on the referenced Chromium snapshots being valid and the WASM browser test legs passing in CI, which is the appropriate signal for this kind of change rather than static review. No functional product code is touched. LGTM.
Detailed Findings
No actionable findings. This is a self-consistent automated browser-version bump touching only test-infrastructure version pins; verification should rely on the WASM browser test legs in CI.
Note
This review was generated by this repository's Holistic Review agentic workflow to complement the built-in Copilot review.
Generated by Holistic Review · 33.9 AIC · ⌖ 10.3 AIC · ⊞ 10K
|
fix for the perf pipeline is #131026 |
No description provided.