Skip to content

Add Markdown annotation idempotency test#356

Merged
OdenTakashi merged 1 commit into
drwl:mainfrom
aouxwoux:codex/fix-markdown-annotation-detection
Jul 15, 2026
Merged

Add Markdown annotation idempotency test#356
OdenTakashi merged 1 commit into
drwl:mainfrom
aouxwoux:codex/fix-markdown-annotation-detection

Conversation

@aouxwoux

@aouxwoux aouxwoux commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Adds a regression test for re-running AnnotateRb on an already annotated Markdown model. It verifies the behavior merged in #354 without duplicating that implementation.

Validation:

  • bundle exec rake spec:unit
  • bundle exec standardrb spec/lib/annotate_rb/model_annotator/single_file_annotator_spec.rb
  • git diff --check

@drwl

drwl commented Jul 14, 2026

Copy link
Copy Markdown
Owner

Thanks for submitting this PR. It seems like #354 covers the same changes and also includes a more in depth write up, so I went and merged that one.

I'd hate to completely dismiss a contribution, but I did notice that the single_file_annotator_spec.rb change could still be valuable. If you want to submit that I'd be happy to merge that in.

@aouxwoux aouxwoux force-pushed the codex/fix-markdown-annotation-detection branch from 5a552f2 to e8cb579 Compare July 14, 2026 07:17
@aouxwoux aouxwoux changed the title Fix Markdown annotation detection Add Markdown annotation idempotency test Jul 14, 2026

@OdenTakashi OdenTakashi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this. Looks good to me.

@OdenTakashi OdenTakashi merged commit a4d52de into drwl:main Jul 15, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants