chore: refactor launch tests#31
Closed
dsnsgithub wants to merge 7 commits into
Closed
Conversation
The launch tests previously shipped three test-driver flavours (modern gametest, legacy gametest with a near-identical copied source file, and a pre-gametest fallback). Replace them with the single fallback-style driver for every supported Minecraft version: the client joins a pre-generated survival world via --quickPlaySingleplayer, screenshots the HUD, and exits. One source file now compiles and runs against 1.21-26.2: - the auto-named Screenshot.grab overload is the only one whose signature is stable across all versions, so the driver renames its output instead of naming it up front - Minecraft.getMainRenderTarget() moved to GameRenderer in 26.2, so the accessor is resolved by name at runtime (Mojang name on unobfuscated 26.x, version-stable intermediary name on obfuscated 1.21.x) Every Minecraft symbol the driver uses was verified against the official Mojang mappings of all 12 obfuscated versions, and the source was compiled directly against the unobfuscated 26.1 and 26.2 client jars. This removes the clientGametest split everywhere: the fabric client gametest dependency and jvm args, the per-flavour source-set selection, the conditional pregen_world CI matrix field, and the title-screen screenshots (only the survival screenshots feed the PR report). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FpvdqYScz6nusUf9qioyg9
BetterHUD Launch Screenshots
|
supported-versions.json is gone. The versions/ folder is now the single source of truth: CI expands each variant's mc_dep range against Mojang's version manifest to enumerate the Minecraft versions to build, launch-test, and publish for, so new patch releases are picked up with no repo change. The launch test resolves the latest Fabric API, Mod Menu, and Cloth Config releases for the tested Minecraft version from the Modrinth API at dependency-resolution time — the same versions a launcher would install — instead of hardcoding them per version. Verified to reproduce the previously pinned versions exactly. The launchtest project moves to src/launchtest since it is source code, and all comments outside src/main/java are removed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FpvdqYScz6nusUf9qioyg9
dsnsgithub
changed the title
Refactor screenshot availability check in build.yml.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove redundant launch tests and remove AI slop from the testing framework.