chore(cli): align indirect x/crypto with the server (v0.52.0 → v0.54.0)#150
Merged
Conversation
The CLI resolved golang.org/x/crypto to v0.52.0 while the server requires v0.54.0. Pure hygiene — it does NOT change the module's vulnerability status: govulncheck reports 0 before and after. In particular this does not address GO-2026-5932 (x/crypto/openpgp is unmaintained and unsafe by design) and nothing can, because that advisory has no fixed version — the upstream remedy is "do not use the package". It is also a non-issue here: openpgp is not part of this binary at all. `go list -deps` does not include it, the released binary contains zero references to it, and source-mode govulncheck reports 0. It only surfaces when scanning the released binary in -mode=binary: release builds are stripped (-s -w), so govulncheck cannot do symbol analysis and falls back to module-level reporting — visible in its output as package wildcards (`openpgp/armor/*`) rather than real called symbols. x/crypto is pulled in solely for sha3, via go-playground/validator. Also carries the x/sys and x/text bumps that came with the upgrade. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings
developlevel withmain, which is ahead by exactly this change(everything else already reached develop via cherry-picks).
What this is
The CLI resolved
golang.org/x/cryptoto v0.52.0 while the server requiresv0.54.0. This aligns them, and carries the
x/sysandx/textbumps that camealong with the upgrade.
Pure hygiene — it changes no vulnerability status.
govulncheckreports 0before and after.
What it deliberately does NOT do
It does not address GO-2026-5932 (
x/crypto/openpgpis unmaintained andunsafe by design), and nothing can: that advisory has
Fixed in: N/A, becausethe upstream remedy is "stop using the package", not "upgrade".
It is also a non-issue for this binary — verified three ways:
go list -deps ./...does not includeopenpgpat all;cixbinary contains zero references to it(
strings | grep -c crypto/openpgp→ 0);govulncheck(real reachability analysis) reports 0.It only appears when scanning the released binary with
-mode=binary: releasebuilds are stripped (
-ldflags "-s -w"), so govulncheck cannot do symbolanalysis and falls back to module-level reporting. Its own output gives this
away — the "vulnerable symbols" are package wildcards (
openpgp/armor/*,openpgp/clearsign/*) rather than concrete called symbols.x/cryptois pulledin solely for
sha3, viago-playground/validator.Release status
Nothing is tagged for this.
cli/v0.10.1andserver/v0.12.4are the currentreleases and both already contain the real fixes (CLI security rebuild on
go1.25.12, corrected module path, toolchain alignment). This commit would ship
with whatever CLI release comes next — cutting one just for it is not worth it
unless you want the released artifact to carry the newer x/crypto.
🤖 Generated with Claude Code