chore: carry symbol-table build fixes to develop (#151, #152)#154
Merged
Conversation
…ep -w) Stripped binaries (-s) force govulncheck -mode=binary into module-level fallback: it cannot see which packages are actually linked, so it flags every advisory on every required module — including GO-2026-5932 (x/crypto/openpgp), a package this binary does not contain at all. With the symbol table present govulncheck does real symbol-level analysis. Verified locally on the current cli/ tree: -s -w : 13.5 MB, binary scan reports "affected by 1 vulnerability" -w : 15.0 MB, binary scan reports 0 (openpgp correctly unreachable) none : 20.0 MB, binary scan reports 0 -w (DWARF stripping) stays, so the size cost is ~+11%, not +48%. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> (cherry picked from commit 07618f1)
…p -w) Companion to #151, which does the same for the CLI. Both server images still build with `-ldflags "-s -w"`, so the shipped cix-server binary has no symbol table and any binary-mode vulnerability scan of the published image degrades to module-level reporting — flagging advisories for packages that are not linked at all. Measured on this binary, the same false positive #151 removes from the CLI is present here: -s -w : 24.0 MB, 143 symbols -> "affected by 1 vulnerability from 1 module" -w : 25.7 MB, 26 377 symbols -> "No vulnerabilities found" Cost is +6.8% on the binary (~1.7 MB) inside images of ~172 MB (CPU) and ~1.5 GB (CUDA), so it is noise at the image level. `-w` still drops DWARF. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> (cherry picked from commit 65bd2dc)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picks the two symbol-table build changes from main (#151, #152) onto
develop — replaces #153, whose direct main→develop merge conflicted because
the branches share content via cherry-picks, not merge history.
After this,
git diff develop mainis empty. Merging also triggersprerelease-cli.yml, so the floatingcli/developbuild will be the firstartifact produced with the symbol table kept.
🤖 Generated with Claude Code