Switch all platforms to the MctpSerial uart-service#6
Closed
dymk wants to merge 1 commit into
Closed
Conversation
Every platform drove its uart-service through `DefaultService::default_smbusespi` (SMBus/eSPI framing). Switch all five to `MctpSerialService::default_mctp_serial` so the EC link speaks DSP0253 serial (`MctpSerialMedium`) — the same framing the rest of the stack now uses — and retire the SMBus/eSPI path. `ec-test-cli` was updated to speak DSP0253 in odp-platform-common; bump `EC_TEST_CLI_REV` to that revision so the dev-qemu integration test exercises the unified wire format end to end. Assisted-by: GitHub Copilot:claude-opus-4.8
dymk
force-pushed
the
dymk/unify-ec-platforms-serial
branch
from
a2941cd to
d1ec9f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every platform drove its uart-service through
DefaultService::default_smbusespi(SMBus/eSPI framing). This switches all five —dev-imxrt,dev-mcxa,dev-mec,dev-npcx,dev-qemu— toMctpSerialService::default_mctp_serial, so the EC link speaks DSP0253 serial (MctpSerialMedium), the same framing the rest of the stack now uses, and retires the SMBus/eSPI path.This is the EC step of unifying the EC link on DSP0253 serial:
odp-platform-common—ec-test-lib/ec-test-cli→ DSP0253 (#132, merged).default_mctp_serial, and bump theec-test-clipin to that merge.embedded-services: retire the now-unuseduart_service::default_smbusespi.What changed
platform/*/src/main.rs(all 5):uart_service::DefaultService::default_smbusespi(relay).unwrap()→uart_service::MctpSerialService::default_mctp_serial(relay).expect("failed to init MctpSerial uart-service"), and the matchingStaticCelltype. The diff is identical across all five platforms..github/workflows/check.yml:EC_TEST_CLI_REV→2034778(the merged DSP0253ec-test-cli), so thedev-qemuintegration-test job exercises the unified wire format end to end.Testing
cargo build --locked --release,cargo clippy --locked -- -D warnings, andcargo fmt --checkpass for all five platforms.scripts/integration-test.sh(buildsdev-qemuand drives it with the bumpedec-test-cli) locally — all thermal/battery/RTC commands round-trip over DSP0253, including the multi-packetbattery get-bixresponse.SUCCESS: Integration test passed!Note
dev-mecis switched here for consistency (and so it doesn't break whendefault_smbusespiis later removed), but note it is not currently part of the CI matrix incheck.yml— its build/lint are not exercised by CI.