Harden GCE Terraform generation and add equivalence coverage - #3
Merged
Conversation
Refresh expected manager update policies after rendering max_unavailable_fixed. This restores the GCE integration tests for the fork's existing Terraform change.
The API target adds a principal without owning the full role binding, but the Terraform target emitted an authoritative binding that could remove unrelated principals. Use google_project_iam_member so both targets have the same additive semantics.
Exercise the kops-module topology without cloud credentials using generic fixture identities and deterministic PKI.
Explain the state transition from authoritative IAM bindings and mark the deterministic PKI as public test material.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
google_project_iam_memberresourcesUpgrade note
Existing generated GCE Terraform state may contain:
google_project_iam_binding.serviceaccount-control-planegoogle_project_iam_binding.serviceaccount-nodesAfter regenerating the configuration and before planning, remove those old addresses with
terraform state rm. The migration is documented indocs/terraform.md.Testing
make quick-cimake testmake all examplesmake verify-terraformTestGCEKopsModuleEquivalenceregeneration/kind bug
/area provider/gcp