feat(task): auto-flatten subtasks inline when the nesting limit is reached - #22
Open
easonLiangWorldedtech wants to merge 4 commits into
Open
feat(task): auto-flatten subtasks inline when the nesting limit is reached#22easonLiangWorldedtech wants to merge 4 commits into
easonLiangWorldedtech wants to merge 4 commits into
Conversation
Part 1/8 of the task-tree series (upstream-ready recomposition). Adds `depth` to HistoryItem and a cycle-safe `backfillTaskDepth()` that propagates parent depth through the delegation tree, so every task knows its nesting level. Depth is surfaced for later use by settings validation, environment details, and history-tree display. Includes the single-open-invariant spec mock for backfillTaskDepth (folded in from the series' CI fix) so this PR passes unit tests standalone. Depth contract hardening: - Children inherit their live parent's depth authority instead of assuming it, so a legacy non-authoritative parent never stamps its placeholder depth onto the child as a persisted fact (regression test added). - computeTaskDepth now processes an ancestor reached after exactly MAX_DEPTH_WALK hops; only strictly longer chains are rejected (boundary regression test added).
…ound-trip Part 2/8 of the task-tree series (upstream-ready recomposition). Adds two global settings that control subtask delegation: - `maxNestingDepth` (default 2, range 0-5): how many levels a subtask may nest. A value of 0 disables delegation entirely — every new_task runs inline. - `autoFlattenOnLimit` (default true): when the limit is reached, flatten the subtask into the current conversation instead of opening a new tab; when disabled such requests are rejected so you can continue directly. Full round trip: global-settings schema + defaults, ExtensionState, SettingsView control bound to cachedState with save payload, webviewMessageHandler persistence through ContextProxy, ClineProvider getState/getStateToPostToWebview, runtime consumers using the shared defaults. Includes focused tests for UI binding/save, persistence, and the saved value returned to the webview. Also completes the taskTree translation keys in all 17 non-English locales so check-translations passes standalone (folded in from the series' CI fix).
…ached (#12) Co-authored-by: Eason Liang <easonliang28@gmail.com>
Adds a three-level new_task chain e2e (root -> child -> depth-2 task) where the depth-2 task's own new_task call exceeds maxNestingDepth and is flattened inline. Asserts exactly 3 tasks exist, the flattened work completes in the depth-2 task's own conversation, parent/child resume correctly, and the task stack never holds a fourth task. Hand-written aimock fixtures (no API key needed) use unique FLATTEN_E2E_ markers with predicate matching to avoid cross-suite collisions.
easonLiangWorldedtech
marked this pull request as ready for review
August 17, 2026 02:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 3/8 of the task-tree series (builds on parts 1-2). Two commits: feature + e2e coverage.
Description
When a new_task call would exceed maxNestingDepth and autoFlattenOnLimit is set, the subtask is flattened into the current conversation instead of opening a new tab: the marker records the staged instruction + todos, a directive is pushed to the model, and attempt_completion during the phase ends the phase without completing the task. Nested new_task calls during an active phase are rejected with guidance to complete the inline work first.
Commit 2 adds e2e coverage across the real extension host: a three-level new_task chain where the depth-2 task's own call is flattened — asserts exactly 3 tasks exist, the flattened work completes in-conversation, parents resume correctly, and no fourth tab opens. Hand-written aimock fixtures (no API key needed).
Test Procedure
pnpm --dir src exec vitest run core/tools/__tests__/inlineSubtask.spec.ts core/tools/__tests__/newTaskInlineFlatten.spec.tsUSE_MOCK=true TEST_FILE=inline-flatten.test.js pnpm --filter @roo-code/vscode-e2e test:runPre-Submission Checklist