Audit disabled lint rules and adopt the low-risk subset#194
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #194 +/- ##
===========================================
- Coverage 82.26% 80.24% -2.02%
===========================================
Files 88 263 +175
Lines 5451 22210 +16759
Branches 454 2587 +2133
===========================================
+ Hits 4484 17823 +13339
- Misses 802 3411 +2609
- Partials 165 976 +811
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inventories every disabled Ruff rule, measures how many issues each would
raise today, and recommends — rule by rule — which to switch on (with fixes)
and which to keep off because they reflect deliberate conventions. The
roadmap lives in
docs/dev/plans/lint-rule-audit.md, with atools/lint_rule_audit.pyhelper that regenerates the inventory on demand.Acts on the low-risk subset:
B011,B017,N805,PLE, docsANN).D100/D104module & package docstrings (79 added),DTZ005, theTD004/TD005TODO-format rules, and test hygiene(
I001/E501/F841).PLR/PLWin tests) androute the library's stray diagnostic
print()s through itsLogger(
T20).Also refreshes the saved tutorial fit-result baselines for the merged
auto_estimatebackground feature (#193). Remaining Tier-B/C rules aredocumented as deliberate keep-disabled recommendations.
Verification:
pixi run check,unit-tests(2092),integration-tests(160), and
script-tests(25) all pass.🤖 Generated with Claude Code