mw/com: Add integartion tests for getter-enabled field variants - #783
Draft
sahithi-nukala wants to merge 8 commits into
Draft
mw/com: Add integartion tests for getter-enabled field variants#783sahithi-nukala wants to merge 8 commits into
sahithi-nukala wants to merge 8 commits into
Conversation
- Automatically register a Get handler for fields with EnableGet. - Serve Get requests by reading the latest field value and returning it through the Get method. - Add a test covering this behavior. Issue: SWP-249517
- pass additional_slots through field binding creation - compute additional_slots from EnableSet || EnableGet - use configured_slots + additional_slots in event properties - add unit tests for +1 and default (unchanged) slot count
- Added the RegisterHandler(callback, QualityType) overload - Extended TypeErasedCallbackSignature with QualityType as 3rd param - Capture asil_level in OnProxyMethodSubscribeFinished so each proxy connection carries its own ASIL level at call time - Updated BUILD visibility/deps for quality type
- Update RegisterGetHandler() to use QualityType-aware RegisterHandler overload - Fixed the unit test case by adding qualitytype as param
…d fixed clang tidy error
- Pass WithGetter tag presence from SkeletonField down to lola::SkeletonEvent via the field binding factory chain, replacing the hard-coded false value. - Merge both RegisterHandler overloads into one RegisterHandlerImpl and passed QualityType only when the callback accepts it - Expose all args of CreateEventBinding in mock
sahithi-nukala
force-pushed
the
sah_add_getter_integration_tests
branch
from
July 27, 2026 12:24
50430cd to
710e1df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.