feat: docs_bundle - #671
Draft
AlexanderLanin wants to merge 5 commits into
Draft
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //src:license-checkStatus: Click to expand output |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| runtime_mounts: list[dict[str, object]] = [] | ||
| for spec in manifest.mounts: | ||
| walk_dir = _resolve_walk_dir(manifest, spec, ws_root) | ||
| if not walk_dir.is_dir(): |
| (tmp_path / "src").symlink_to(runfiles_workspace / "src", target_is_directory=True) | ||
|
|
||
| copied_source_dir = tmp_path / "docs" | ||
| shutil.copytree(source_dir, copied_source_dir) |
| env["SCORE_SOURCELINKS"] = str(sourcelinks) | ||
|
|
||
| return subprocess.run( | ||
| [str(docs_binary)], |
| runtime_mounts: list[dict[str, object]] = [] | ||
| for spec in manifest.mounts: | ||
| walk_dir = _resolve_walk_dir(manifest, spec, ws_root) | ||
| if not walk_dir.is_dir(): |
| (tmp_path / "src").symlink_to(runfiles_workspace / "src", target_is_directory=True) | ||
|
|
||
| copied_source_dir = tmp_path / "docs" | ||
| shutil.copytree(source_dir, copied_source_dir) |
| env["SCORE_SOURCELINKS"] = str(sourcelinks) | ||
|
|
||
| return subprocess.run( | ||
| [str(docs_binary)], |
a-zw
reviewed
Jul 28, 2026
|
|
||
| docs_sources_env["ACTION"] = "incremental" | ||
| py_binary( | ||
| name = "docs_combo", |
Contributor
There was a problem hiding this comment.
Moving too fast. Keep docs_combo for backwards-compatibility.
a-zw
reviewed
Jul 28, 2026
| known_good_label = [known_good] if known_good else [] | ||
| # The public bundle carries both the complete source tree and the | ||
| # transitive source-code links of every nested bundle. | ||
| docs_bundle( |
Contributor
There was a problem hiding this comment.
I guess you are replacing the combo approach with mounts? Too fast, we should stay backwards-compatible here for now.
Member
Author
There was a problem hiding this comment.
No way to do that. But thats not a problem, as it simply means we need to perform a "bigger PR" in ref int when updating -> 10-20 LOC.
Co-authored-by: Maximilian Sören Pollak <maximilian.pollak@qorix.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bundles!
📌 Description
🚨 Impact Analysis
✅ Checklist