Avoid deadlocks after fork - #303
Open
danth wants to merge 4 commits into
Open
Conversation
2 tasks
This comment was marked as outdated.
This comment was marked as outdated.
danth
force-pushed
the
avoid-deadlocks-after-fork
branch
from
July 10, 2026 08:09
bcb913a to
2a70190
Compare
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
danth
force-pushed
the
avoid-deadlocks-after-fork
branch
from
July 10, 2026 08:22
2a70190 to
9cc08d6
Compare
MaciejKaszynski
requested changes
Jul 14, 2026
danth
force-pushed
the
avoid-deadlocks-after-fork
branch
from
July 14, 2026 09:57
9cc08d6 to
67c0d0f
Compare
danth
force-pushed
the
avoid-deadlocks-after-fork
branch
from
July 14, 2026 10:05
67c0d0f to
9c28979
Compare
MaciejKaszynski
previously approved these changes
Jul 14, 2026
danth
force-pushed
the
avoid-deadlocks-after-fork
branch
from
July 15, 2026 10:33
e249b48 to
4121230
Compare
paulquiring
reviewed
Jul 24, 2026
paulquiring
reviewed
Jul 24, 2026
danth
force-pushed
the
avoid-deadlocks-after-fork
branch
from
July 24, 2026 08:31
eec0536 to
6422d23
Compare
danth
force-pushed
the
avoid-deadlocks-after-fork
branch
from
July 24, 2026 09:05
6422d23 to
03a36bc
Compare
Member
Author
|
Tests failed due to a network error. |
danth
force-pushed
the
avoid-deadlocks-after-fork
branch
from
July 27, 2026 08:43
03a36bc to
8402f02
Compare
danth
force-pushed
the
avoid-deadlocks-after-fork
branch
from
July 27, 2026 09:20
8402f02 to
e66cd1f
Compare
danth
force-pushed
the
avoid-deadlocks-after-fork
branch
from
July 28, 2026 12:57
e66cd1f to
ea37191
Compare
Member
Author
|
New implementation considering previous feedback:
|
danth
force-pushed
the
avoid-deadlocks-after-fork
branch
from
July 28, 2026 13:30
ea37191 to
2026010
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork only copies the current thread, so from that point on we could deadlock if we access anything that was locked by another thread at the time of the fork.
According to
man 2 forkwe should only use async signal safe functions betweenforkandexecve.