Skip to content

Avoid deadlocks after fork - #303

Open
danth wants to merge 4 commits into
eclipse-score:mainfrom
etas-contrib:avoid-deadlocks-after-fork
Open

Avoid deadlocks after fork#303
danth wants to merge 4 commits into
eclipse-score:mainfrom
etas-contrib:avoid-deadlocks-after-fork

Conversation

@danth

@danth danth commented Jul 9, 2026

Copy link
Copy Markdown
Member

Fork only copies the current thread, so from that point on we could deadlock if we access anything that was locked by another thread at the time of the fork.

According to man 2 fork we should only use async signal safe functions between fork and execve.

@danth

This comment was marked as outdated.

@danth
danth force-pushed the avoid-deadlocks-after-fork branch from bcb913a to 2a70190 Compare July 10, 2026 08:09
@danth
danth requested a deployment to workflow-approval July 10, 2026 08:09 — with GitHub Actions Waiting
@danth
danth requested a deployment to workflow-approval July 10, 2026 08:09 — with GitHub Actions Waiting
@github-actions

github-actions Bot commented Jul 10, 2026

Copy link
Copy Markdown

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: 63381e2f-9846-4148-9917-bf0885655cad
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (34 packages loaded, 10 targets configured)

Analyzing: target //:license-check (85 packages loaded, 10 targets configured)

Analyzing: target //:license-check (141 packages loaded, 2459 targets configured)

Analyzing: target //:license-check (151 packages loaded, 5480 targets configured)

Analyzing: target //:license-check (152 packages loaded, 5571 targets configured)

Analyzing: target //:license-check (163 packages loaded, 8263 targets configured)

Analyzing: target //:license-check (164 packages loaded, 8271 targets configured)

Analyzing: target //:license-check (164 packages loaded, 8271 targets configured)

Analyzing: target //:license-check (164 packages loaded, 8271 targets configured)

Analyzing: target //:license-check (167 packages loaded, 10159 targets configured)

Analyzing: target //:license-check (168 packages loaded, 10283 targets configured)

INFO: Analyzed target //:license-check (169 packages loaded, 10409 targets configured).
[13 / 16] JavaToolchainCompileClasses external/rules_java+/toolchains/platformclasspath_classes; 0s disk-cache, processwrapper-sandbox
[14 / 16] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar; 0s disk-cache, processwrapper-sandbox
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 24.280s, Critical Path: 2.56s
INFO: 16 processes: 12 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@github-actions

Copy link
Copy Markdown

The created documentation from the pull request is available at: docu-html

@danth
danth force-pushed the avoid-deadlocks-after-fork branch from 2a70190 to 9cc08d6 Compare July 10, 2026 08:22
@danth
danth requested a deployment to workflow-approval July 10, 2026 08:22 — with GitHub Actions Waiting
@danth
danth requested a deployment to workflow-approval July 10, 2026 08:22 — with GitHub Actions Waiting
@danth
danth force-pushed the avoid-deadlocks-after-fork branch from 9cc08d6 to 67c0d0f Compare July 14, 2026 09:57
@danth
danth requested a deployment to workflow-approval July 14, 2026 09:57 — with GitHub Actions Waiting
@danth
danth requested a deployment to workflow-approval July 14, 2026 09:57 — with GitHub Actions Waiting
@danth
danth force-pushed the avoid-deadlocks-after-fork branch from 67c0d0f to 9c28979 Compare July 14, 2026 10:05
@danth
danth requested a deployment to workflow-approval July 14, 2026 10:05 — with GitHub Actions Waiting
@danth
danth requested a deployment to workflow-approval July 14, 2026 10:05 — with GitHub Actions Waiting
@danth
danth requested a deployment to workflow-approval July 14, 2026 10:37 — with GitHub Actions Waiting
@danth
danth requested a deployment to workflow-approval July 14, 2026 10:37 — with GitHub Actions Waiting
@danth
danth force-pushed the avoid-deadlocks-after-fork branch from e249b48 to 4121230 Compare July 15, 2026 10:33
@danth
danth force-pushed the avoid-deadlocks-after-fork branch from eec0536 to 6422d23 Compare July 24, 2026 08:31
@danth
danth requested a deployment to workflow-approval July 24, 2026 08:31 — with GitHub Actions Waiting
@danth
danth requested a deployment to workflow-approval July 24, 2026 08:31 — with GitHub Actions Waiting
@danth
danth force-pushed the avoid-deadlocks-after-fork branch from 6422d23 to 03a36bc Compare July 24, 2026 09:05
@danth
danth temporarily deployed to workflow-approval July 24, 2026 09:05 — with GitHub Actions Inactive
@danth
danth temporarily deployed to workflow-approval July 24, 2026 09:05 — with GitHub Actions Inactive
@danth

danth commented Jul 24, 2026

Copy link
Copy Markdown
Member Author

Tests failed due to a network error.

@danth
danth force-pushed the avoid-deadlocks-after-fork branch from 03a36bc to 8402f02 Compare July 27, 2026 08:43
@danth
danth requested a deployment to workflow-approval July 27, 2026 08:43 — with GitHub Actions Waiting
@danth
danth requested a deployment to workflow-approval July 27, 2026 08:43 — with GitHub Actions Waiting
@danth
danth force-pushed the avoid-deadlocks-after-fork branch from 8402f02 to e66cd1f Compare July 27, 2026 09:20
@danth
danth requested a deployment to workflow-approval July 27, 2026 09:20 — with GitHub Actions Waiting
@danth
danth requested a deployment to workflow-approval July 27, 2026 09:20 — with GitHub Actions Waiting
@danth
danth force-pushed the avoid-deadlocks-after-fork branch from e66cd1f to ea37191 Compare July 28, 2026 12:57
@danth
danth requested a deployment to workflow-approval July 28, 2026 12:57 — with GitHub Actions Waiting
@danth
danth requested a deployment to workflow-approval July 28, 2026 12:57 — with GitHub Actions Waiting
@danth

danth commented Jul 28, 2026

Copy link
Copy Markdown
Member Author

New implementation considering previous feedback:

  • Use a separate function, not the assertion handler, so it cannot be swapped out for something unsafe
  • Use signal safe implementations of strerror, otherwise fall back to printing the raw error number
  • Build the error message in a fixed size buffer to avoid allocations and multiple writes
  • Comments on all affected functions to avoid later changes making this unsafe again
  • Minimal diff to aid review

@danth
danth force-pushed the avoid-deadlocks-after-fork branch from ea37191 to 2026010 Compare July 28, 2026 13:30
@danth
danth requested a deployment to workflow-approval July 28, 2026 13:30 — with GitHub Actions Waiting
@danth
danth requested a deployment to workflow-approval July 28, 2026 13:30 — with GitHub Actions Waiting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Ready

Development

Successfully merging this pull request may close these issues.

5 participants