Carve FixedSizeQueue out of MpscBoundedQueue - #367
Merged
MaciejKaszynski merged 1 commit intoJul 28, 2026
Merged
Conversation
paulquiring
temporarily deployed
to
workflow-approval
July 24, 2026 12:06 — with
GitHub Actions
Inactive
paulquiring
temporarily deployed
to
workflow-approval
July 24, 2026 12:06 — with
GitHub Actions
Inactive
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
paulquiring
commented
Jul 24, 2026
|
The created documentation from the pull request is available at: docu-html |
paulquiring
commented
Jul 24, 2026
WilliamRoebuck
approved these changes
Jul 24, 2026
WilliamRoebuck
left a comment
Contributor
There was a problem hiding this comment.
Looks good overall, only minor comments
Contributor
|
Should we move this out to a separate file if it is a reusable container? |
paulquiring
requested a deployment
to
workflow-approval
July 27, 2026 09:02 — with
GitHub Actions
Waiting
paulquiring
requested a deployment
to
workflow-approval
July 27, 2026 09:02 — with
GitHub Actions
Waiting
Contributor
Author
fixed in last commit |
paulquiring
requested a deployment
to
workflow-approval
July 27, 2026 17:55 — with
GitHub Actions
Waiting
paulquiring
requested a deployment
to
workflow-approval
July 27, 2026 17:55 — with
GitHub Actions
Waiting
paulquiring
force-pushed
the
feature/carve-FixedSizeQueue-out-of-MpscBoundedQueue
branch
from
July 28, 2026 07:22
98407da to
3da52fb
Compare
paulquiring
requested a deployment
to
workflow-approval
July 28, 2026 07:22 — with
GitHub Actions
Waiting
paulquiring
requested a deployment
to
workflow-approval
July 28, 2026 07:22 — with
GitHub Actions
Waiting
Contributor
Author
|
@NicolasFussberger is ready to merge from my side. I squashed the commits into one. |
paulquiring
deleted the
feature/carve-FixedSizeQueue-out-of-MpscBoundedQueue
branch
July 28, 2026 09:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Carve FixedSizeQueue out of MpscBoundedQueue for reuse.
MpscBoundedQueues capacity can be set now at runtime, to allow
setting the capacity based on configuration.