Skip to content

Carve FixedSizeQueue out of MpscBoundedQueue - #367

Merged
MaciejKaszynski merged 1 commit into
eclipse-score:mainfrom
etas-contrib:feature/carve-FixedSizeQueue-out-of-MpscBoundedQueue
Jul 28, 2026
Merged

Carve FixedSizeQueue out of MpscBoundedQueue#367
MaciejKaszynski merged 1 commit into
eclipse-score:mainfrom
etas-contrib:feature/carve-FixedSizeQueue-out-of-MpscBoundedQueue

Conversation

@paulquiring

@paulquiring paulquiring commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Carve FixedSizeQueue out of MpscBoundedQueue for reuse.
MpscBoundedQueues capacity can be set now at runtime, to allow
setting the capacity based on configuration.

@github-actions

github-actions Bot commented Jul 24, 2026

Copy link
Copy Markdown

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: 59063958-5446-4dfd-aa1d-2d6b8a868653
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (33 packages loaded, 10 targets configured)

Analyzing: target //:license-check (86 packages loaded, 10 targets configured)

Analyzing: target //:license-check (139 packages loaded, 695 targets configured)

Analyzing: target //:license-check (152 packages loaded, 3439 targets configured)

Analyzing: target //:license-check (152 packages loaded, 5482 targets configured)

Analyzing: target //:license-check (156 packages loaded, 8212 targets configured)

Analyzing: target //:license-check (164 packages loaded, 8269 targets configured)

Analyzing: target //:license-check (164 packages loaded, 8271 targets configured)

Analyzing: target //:license-check (164 packages loaded, 8271 targets configured)

Analyzing: target //:license-check (167 packages loaded, 10159 targets configured)

Analyzing: target //:license-check (168 packages loaded, 10283 targets configured)

INFO: Analyzed target //:license-check (169 packages loaded, 10409 targets configured).
[12 / 16] JavaToolchainCompileClasses external/rules_java+/toolchains/platformclasspath_classes; 0s disk-cache, processwrapper-sandbox ... (2 actions running)
[14 / 16] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar; 0s disk-cache, processwrapper-sandbox
[15 / 16] Building license.check.license_check.jar (); 0s disk-cache, multiplex-worker
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 24.746s, Critical Path: 2.89s
INFO: 16 processes: 12 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

Comment thread score/launch_manager/src/daemon/src/common/concurrency/mpsc_bounded_queue.hpp Outdated
@github-actions

Copy link
Copy Markdown

The created documentation from the pull request is available at: docu-html

Comment thread score/launch_manager/src/daemon/src/common/concurrency/mpsc_bounded_queue.hpp Outdated

@WilliamRoebuck WilliamRoebuck left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, only minor comments

Comment thread score/launch_manager/src/daemon/src/common/concurrency/mpsc_bounded_queue.hpp Outdated
Comment thread score/launch_manager/src/daemon/src/common/concurrency/mpsc_bounded_queue.hpp Outdated
Comment thread score/launch_manager/src/daemon/src/common/concurrency/mpsc_bounded_queue.hpp Outdated
@NicolasFussberger

Copy link
Copy Markdown
Contributor

Should we move this out to a separate file if it is a reusable container?

Comment thread score/launch_manager/src/daemon/src/common/concurrency/mpsc_bounded_queue.hpp Outdated
@paulquiring

Copy link
Copy Markdown
Contributor Author

Should we move this out to a separate file if it is a reusable container?

fixed in last commit

Comment thread score/launch_manager/src/daemon/src/common/concurrency/fixed_size_queue.hpp Outdated
Comment thread score/launch_manager/src/daemon/src/common/concurrency/fixed_size_queue_test.cpp Outdated
Comment thread score/launch_manager/src/daemon/src/common/concurrency/fixed_size_queue_test.cpp Outdated
@paulquiring
paulquiring force-pushed the feature/carve-FixedSizeQueue-out-of-MpscBoundedQueue branch from 98407da to 3da52fb Compare July 28, 2026 07:22
@paulquiring

Copy link
Copy Markdown
Contributor Author

@NicolasFussberger is ready to merge from my side. I squashed the commits into one.

@MaciejKaszynski MaciejKaszynski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@MaciejKaszynski
MaciejKaszynski merged commit 2b82ed2 into eclipse-score:main Jul 28, 2026
20 of 23 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in LCM - Lifecycle & Health FT Jul 28, 2026
@paulquiring
paulquiring deleted the feature/carve-FixedSizeQueue-out-of-MpscBoundedQueue branch July 28, 2026 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants