Adding OSAL inotify - #379
Draft
MaciejKaszynski wants to merge 2 commits into
Draft
Conversation
MaciejKaszynski
requested a deployment
to
workflow-approval
July 28, 2026 16:31 — with
GitHub Actions
Waiting
MaciejKaszynski
requested a deployment
to
workflow-approval
July 28, 2026 16:31 — with
GitHub Actions
Waiting
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
MaciejKaszynski
requested a deployment
to
workflow-approval
July 29, 2026 07:02 — with
GitHub Actions
Waiting
MaciejKaszynski
requested a deployment
to
workflow-approval
July 29, 2026 07:02 — with
GitHub Actions
Waiting
MaciejKaszynski
commented
Jul 29, 2026
|
|
||
| score::Result<INotifyWatcher> INotifyWatcher::Create() noexcept | ||
| { | ||
| int event_queue_fd = ::inotify_init1(IN_CLOEXEC); |
Contributor
Author
There was a problem hiding this comment.
Move to baselibs if eclipse-score/baselibs#420 is done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding an osal layer for
inotify.The
INotifyWatcheris exposes an iterator that wraps the reading from the inotify event queue file, new events appear when available and things are blocked withepoll_waitso that we can sleep. This also allows for interruptions for unit tests.(note I had to do some funky stuff with epoll for this)
Usage: