Skip to content

Rework of component requirements related to snapshots - #337

Open
tizava wants to merge 6 commits into
eclipse-score:mainfrom
etas-contrib:snapshot-comp-req-rework
Open

Rework of component requirements related to snapshots#337
tizava wants to merge 6 commits into
eclipse-score:mainfrom
etas-contrib:snapshot-comp-req-rework

Conversation

@tizava

@tizava tizava commented Jul 10, 2026

Copy link
Copy Markdown
Contributor
  • Snapshots are now explicit (Driven by the users)
  • Snapshots are created from live data (Not from data flushed to disk)
  • New API to acquire status of the snapshot slot (Occupied/Free)
  • General rework and cleanup

@github-actions

github-actions Bot commented Jul 10, 2026

Copy link
Copy Markdown

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: e4a14dc5-1b90-494d-9e44-82b989fd7e2e
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 3 packages loaded
Loading: 3 packages loaded
    currently loading: 
Loading: 3 packages loaded
    currently loading: 
Loading: 3 packages loaded
    currently loading: 
Analyzing: target //:license-check (4 packages loaded, 0 targets configured)
Analyzing: target //:license-check (4 packages loaded, 0 targets configured)

Analyzing: target //:license-check (30 packages loaded, 10 targets configured)

Analyzing: target //:license-check (84 packages loaded, 10 targets configured)

Analyzing: target //:license-check (138 packages loaded, 1180 targets configured)

Analyzing: target //:license-check (139 packages loaded, 2712 targets configured)

Analyzing: target //:license-check (139 packages loaded, 2712 targets configured)

Analyzing: target //:license-check (139 packages loaded, 2712 targets configured)

Analyzing: target //:license-check (149 packages loaded, 5387 targets configured)

Analyzing: target //:license-check (150 packages loaded, 7970 targets configured)

Analyzing: target //:license-check (153 packages loaded, 8079 targets configured)

Analyzing: target //:license-check (161 packages loaded, 8133 targets configured)

Analyzing: target //:license-check (161 packages loaded, 8133 targets configured)

Analyzing: target //:license-check (163 packages loaded, 8257 targets configured)

Analyzing: target //:license-check (165 packages loaded, 10145 targets configured)

INFO: Analyzed target //:license-check (166 packages loaded, 10271 targets configured).
[6 / 17] Creating runfiles tree bazel-out/k8-opt-exec-ST-d57f47055a04/bin/external/score_tooling+/dash/tool/formatters/dash_format_converter.runfiles [for tool]; 0s local ... (2 actions, 1 running)
INFO: From Generating Dash formatted dependency file ...:
INFO: Successfully converted 66 packages from Cargo.lock to bazel-out/k8-fastbuild/bin/formatted.txt
[15 / 17] [Prepa] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar
[16 / 17] [Prepa] Building license.check.license_check.jar ()
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 31.931s, Critical Path: 2.66s
INFO: 17 processes: 12 internal, 4 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 17 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@PandaeDo PandaeDo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look again on the requirements. It seems to me that they are not fully atomic. You can use https://eclipse-score.github.io/process_description//main/process_areas/requirements_engineering/guidance/requirements_templates.html#gd_temp__req_formulation and also the question if the requirement is testable. Understandable they are.

Comment thread score/kvs/docs/requirements/index.rst Outdated
:belongs_to: comp__persistency_snapshot

The component shall maintain a configurable maximum number of snapshots.
The component shall provide APIs to create, restore, and delete snapshots.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please specify amount of APIs. Requirement is not testable without this information.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry but maybe I don't understand your question. The APIs are three, the ones specified in the description of the requirement: create, restore and delete.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is was I meant. How should I know that these are three? I think I would need the information that there are 3 APIs. One for create....

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APIs requirements are now atomic with 1 requirement for each operation

@anmittag

anmittag commented Jul 21, 2026

Copy link
Copy Markdown
Member

@tizava there are checks failing, please adapt and review comments. please care

@tizava
tizava requested a deployment to workflow-approval July 28, 2026 11:11 — with GitHub Actions Waiting
@tizava
tizava requested a deployment to workflow-approval July 28, 2026 11:11 — with GitHub Actions Waiting
@tizava
tizava requested a deployment to workflow-approval July 28, 2026 11:22 — with GitHub Actions Waiting
@tizava
tizava requested a deployment to workflow-approval July 28, 2026 11:22 — with GitHub Actions Waiting
@tizava
tizava requested a deployment to workflow-approval July 28, 2026 11:55 — with GitHub Actions Waiting
@tizava
tizava requested a deployment to workflow-approval July 28, 2026 11:55 — with GitHub Actions Waiting
@tizava
tizava requested a deployment to workflow-approval July 28, 2026 14:28 — with GitHub Actions Waiting
@tizava
tizava requested a deployment to workflow-approval July 28, 2026 14:28 — with GitHub Actions Waiting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

4 participants