[rules score] several dependable element fixes - #371
Merged
Conversation
hoe-jo
commented
Jul 28, 2026
Contributor
- correct sphinx_html_merge link rewriting and drop .doctrees
- Introduce Action mnemonics
- rework sphinx toolchain
- provide reusable building blocks for conf.py
- some refactoring and code deduplication
…rees - add tests for sphinx html merge - fix: cross-module links were depth-blind - fix: single-dependency case took a different code path - fix: dont publish Sphinx's build cache
hoe-jo
requested review from
LittleHuba,
castler,
limdor and
ramceb
as code owners
July 28, 2026 06:44
Coverage ReportCoverage report was generated. Full report can be downloaded from the CI artifacts (expand Artifacts at the bottom of the run). Overall coverage rate: |
- Separate output namespace for the needs rule - Introduce Action mnemonics - Remove unused modules list - simplify tool setup
- html_merge_tool as private attribute - sphinx parameter removed from public API - toolchain macro for easier integration
…azel_sphinx_needs
hoe-jo
force-pushed
the
joho_several_dependable_element_fixes
branch
from
July 28, 2026 07:34
09586b6 to
bcb75b3
Compare
Coverage ReportCoverage report was generated. Full report can be downloaded from the CI artifacts (expand Artifacts at the bottom of the run). Overall coverage rate: |
castler
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.