Skip to content

Refactor sequence diagram -- parser part #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hoe-jo merged 5 commits into from
Jul 30, 2026
Merged

Refactor sequence diagram -- parser part #381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
26bdaeb
support sequence lifecycle commands
melodyoncode Jul 30, 2026
049c9a5
support sequence ref over statements
melodyoncode Jul 30, 2026
6f6592d
support sequence message suffixes and missing endpoints
melodyoncode Jul 30, 2026
19bda8b
support sequence group and return commands
melodyoncode Jul 30, 2026
59b7027
ignore unmodeled sequence diagram syntax
melodyoncode Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plantuml/parser/integration_test/sequence_diagram/comprehensive_sequence_test.puml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,7 @@ group Extended Patterns: Lost and Found Messages

' Lost/found with brackets on different sides
[o-> Actor1 : Right bracket on left
Actor1 -->o[ : Left bracket on right
Actor1 -->o] : Left bracket on right
end group

group Extended Patterns: Activation Markers
Expand All @@ -364,7 +364,7 @@ group Extended Patterns: Ref Blocks

ref over Builder
Another reference block
end
end ref
end group

group Extended Patterns: Dividers with URLs
Expand Down
14 changes: 12 additions & 2 deletions plantuml/parser/puml_parser/src/grammar/common.pest
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,23 +84,33 @@ COMMENT = _{
}

////////////////////////////////////////////////////////////////////////////////
// Ignored Statements
// Ignored Blocks and Statements
//
// Non-structural PlantUML directives such as title, style, layout, and scaling.
// Parsed for completeness but generally skipped in AST construction.
//
// Examples:
// <style> ... </style>
// title System Overview
// skinparam shadowing false
// left to right direction
// scale 1.2
////////////////////////////////////////////////////////////////////////////////
ignored_block = _{
style_block
| note_multiline
}

style_block = { "<style>" ~ EOL ~ (!style_block_end ~ ANY)* ~ style_block_end }
style_block_end = { "</style>" ~ EOL? }

ignored_stmt = _{
direction_stmt
| skinparam_stmt
| title_stmt
| note_single_line
| scale_stmt
| namespace_separator_stmt
| namespace_separator_stmt
}

skinparam_stmt = @{ ^"skinparam" ~ LINE_REST }
Expand Down
Loading
Loading