Skip to content

chore: root-6.40.02#298

Open
wdconinc wants to merge 12 commits into
masterfrom
root-6.40.00
Open

chore: root-6.40.02#298
wdconinc wants to merge 12 commits into
masterfrom
root-6.40.00

Conversation

@wdconinc

@wdconinc wdconinc commented May 21, 2026

Copy link
Copy Markdown
Contributor

Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.

This PR updates ROOT to v6.40.02 (release notes).

Needs:

What is the urgency of this PR?

  • High (please describe reason below)
  • Medium
  • Low

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue: ROOT upgrade)
  • Optimization (issue #__)
  • Updated documentation
  • other: __

Please check if any of the following apply

  • This PR introduces breaking changes. Please describe changes users need to make below.
  • This PR changes default behavior. Please describe changes below.
  • AI was used in preparing this PR. Please describe usage below.

Copilot AI review requested due to automatic review settings May 21, 2026 13:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to upgrade the ROOT version used in the EIC container Spack environment to v6.40.00 by pulling in upstream spack/spack-packages changes via cherry-picks.

Changes:

  • Added three spack/spack-packages cherry-pick commits related to ROOT (v6.36.12, builtin LLVM variant support, v6.40.00).

Comment thread spack-packages.sh Outdated
Copilot AI review requested due to automatic review settings May 21, 2026 13:29

This comment was marked as duplicate.

Copilot AI review requested due to automatic review settings May 21, 2026 14:43

This comment was marked as resolved.

Copilot AI review requested due to automatic review settings May 21, 2026 15:00

This comment was marked as duplicate.

Copilot AI review requested due to automatic review settings May 21, 2026 16:52

This comment was marked as duplicate.

Copilot AI review requested due to automatic review settings May 22, 2026 13:00

This comment was marked as duplicate.

@wdconinc

Copy link
Copy Markdown
Contributor Author

Copilot AI review requested due to automatic review settings June 2, 2026 16:46

This comment was marked as resolved.

@wdconinc

wdconinc commented Jun 3, 2026

Copy link
Copy Markdown
Contributor Author

sim:lowq2_reconstruction https://eicweb.phy.anl.gov/EIC/benchmarks/detector_benchmarks/-/jobs/7934403#L1101:

localrule filter_hepmc_for_training:
    input: warmup.edm4hep.root, /builds/EIC/benchmarks/detector_benchmarks/benchmarks/lowq2_reconstruction/filterHEPMC3.py (cached)
    output: sim_output/lowq2_reconstruction/Low-Q2_Training_Events.hepmc3.tree.root
    jobid: 2
    reason: Missing output files: sim_output/lowq2_reconstruction/Low-Q2_Training_Events.hepmc3.tree.root; Input files updated by another job: warmup.edm4hep.root
    resources: tmpdir=/tmp
fatal error: module map file '../../include/root/ROOT.modulemap' not found
fatal error: module map file '../../include/root/ROOT.modulemap' not found

bench:drich_fixed_eta https://eicweb.phy.anl.gov/EIC/benchmarks/detector_benchmarks/-/jobs/7934618 is the same as in #297 and needs eic/eic-spack#943

@wdconinc wdconinc changed the title chore: root-6.40.00 chore: root-6.40.02 Jun 20, 2026
@wdconinc wdconinc marked this pull request as draft June 20, 2026 17:50
@wdconinc wdconinc marked this pull request as ready for review June 25, 2026 02:49
Copilot AI review requested due to automatic review settings June 25, 2026 02:49
@wdconinc wdconinc enabled auto-merge (squash) June 25, 2026 02:49

This comment was marked as duplicate.

@wdconinc

Copy link
Copy Markdown
Contributor Author

https://eicweb.phy.anl.gov/EIC/benchmarks/detector_benchmarks/-/jobs/8009886#L1102

fatal error: module map file '../../include/root/ROOT.modulemap' not found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants