Skip to content

fix: cuda: rm cernlib#348

Merged
wdconinc merged 1 commit into
masterfrom
cuda-rm-cernlib
Jul 10, 2026
Merged

fix: cuda: rm cernlib#348
wdconinc merged 1 commit into
masterfrom
cuda-rm-cernlib

Conversation

@wdconinc

@wdconinc wdconinc commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.

Of all our containers, cernlib is probably least relevant in the cuda container. This PR removes it from there (it's already gone elsewhere).

What is the urgency of this PR?

  • High (please describe reason below)
  • Medium
  • Low

What kind of change does this PR introduce?

  • Bug fix (issue: probably forgot to remove when we took it out of xl)
  • New feature (issue #__)
  • Optimization (issue #__)
  • Updated documentation
  • other: __

Please check if any of the following apply

  • This PR introduces breaking changes. Please describe changes users need to make below.
  • This PR changes default behavior. Please describe changes below.
  • AI was used in preparing this PR. Please describe usage below.

Copilot AI review requested due to automatic review settings July 9, 2026 01:18
@wdconinc wdconinc enabled auto-merge (squash) July 9, 2026 01:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes cernlib from the CUDA Spack environment spec list, aligning the CUDA container’s package set with the rest of the containers where cernlib has already been removed.

Changes:

  • Drop cernlib from spack-environment/cuda/spack.yaml specs list.

@wdconinc wdconinc requested review from a team and veprbl July 9, 2026 01:22
@wdconinc

wdconinc commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

We nixed it in xl in b4b26ba

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

Capybara summary for PR 348

@wdconinc wdconinc merged commit 7886fa7 into master Jul 10, 2026
92 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants