docs-deploy: Collapse three glob matchers into one#231
Open
reakaleek wants to merge 1 commit into
Open
Conversation
The context script defined matchesGlob inline in the vale-paths block, a bespoke isIgnored with identical semantics, and a matchesPattern whose only real case was the /** suffix. Hoist one matchesGlob and express the other two through it, preserving matchesPattern's fail-open behavior for non-/** shapes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replace the three hand-rolled matchers in
docs-deploy.yml's context script (matchesPattern,isIgnored, and an innermatchesGlob) with one hoistedmatchesGlob.Why
Repo-wide over-engineering audit. All three implemented the same
dir/**/dir/*/ exact semantics;matchesPatternadditionally fails open for other pattern shapes. Triplication, not necessity — this workflow runs onworkflow_runwith no checkout, so string matching against API filenames is the right tool, once.How
One
matchesGlobat the top;isIgnoredbecomesignoreLines.some(...);matchesPatternkeeps its documented fail-open behavior for non-/**patterns. Behavior is byte-for-byte identical.Test plan
Node self-check comparing old and new semantics across
/**,/*, exact,**, empty, and fail-open cases — all pass. actionlint passes.🤖 Generated with Claude Code