Internal: Update PHPCS and fix all errors [TMZ-1049]#669
Merged
Conversation
hein-obox
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
wp-coding-standards/wpcscomposer package from v2.3 to v3.3.0.Remove unneeded exclude rules from
phpcs.xmlfile.Fix all remaining CS errors.
✨ PR Description
1. Problem & Context
Updated PHPCS to v3.3.0 and fixed all resulting violations. Modernized linting configuration to enforce stricter standards while removing overly permissive exclusions that masked issues.
2. What Changed (Where)
phpcs.xmlcomments.php,includes/script.php,settings-*.php,index.php,dynamic-footer.phpcomposer.json,package.jsonmodules/admin-home/components/settings-controller.php3. How It Works
PHPCS v3.3.0 is stricter; the config now scans
.explicitly with proper exclusions (assets/,tests/,vendor/,tmp/) instead of ignoring them inline. Code violations were fixed in-place: translator comment relocation (line positioning), proper parentheses grouping in conditionals, and PHPCS inline suppressions for intentional violations. Lint scripts now delegate to Composer runners from npm for single source of truth.4. Risks
None significant. Changes are formatting/standards compliance only—no logic altered. Lint script simplification removes
--extensions=phpand ignore patterns from npm layer, relying onphpcs.xml(already present). Pre-commit hooks or CI must update command references if they call npm lint scripts directly.Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Description using Guidelines Learn how