Skip to content

int32 overflow for particle checkpointing fixed #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Alcauchy wants to merge 1 commit into
base: master
Choose a base branch
from
+18 −10
Open

int32 overflow for particle checkpointing fixed #218

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 18 additions & 10 deletions src/framework/containers/particles_io.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,22 +130,24 @@ namespace ntt {
}

#if !defined(MPI_ENABLED)
const npart_t nout_offset = 0;
const npart_t nout_total = nout;
const std::size_t nout_offset = 0;
const std::size_t nout_total = nout;
(void)domains_total;
(void)domains_offset;
#else
npart_t nout_offset = 0;
npart_t nout_total = nout;
auto nout_total_vec = std::vector<npart_t>(domains_total);
// global totals/offsets are sums over all ranks and can exceed the
// per-rank `npart_t` (uint32_t) range at large problem sizes, so
// accumulate them in a 64-bit type
std::size_t nout_offset = 0;
std::size_t nout_total = 0;
auto nout_total_vec = std::vector<npart_t>(domains_total);
MPI_Allgather(&nout,
1,
mpi::get_type<npart_t>(),
nout_total_vec.data(),
1,
mpi::get_type<npart_t>(),
MPI_COMM_WORLD);
nout_total = 0;
for (auto r = 0u; r < domains_total; ++r) {
if (r < domains_offset) {
nout_offset += nout_total_vec[r];
Expand Down Expand Up @@ -442,10 +444,13 @@ namespace ntt {
set_npart(npart_read);

#if !defined(MPI_ENABLED)
const npart_t npart_offset = 0u;
const std::size_t npart_offset = 0u;
(void)domains_total;
#else
npart_t npart_offset = 0u;
// global offset is a sum over all ranks and can exceed the per-rank
// `npart_t` (uint32_t) range at large problem sizes, so accumulate
// it in a 64-bit type
std::size_t npart_offset = 0u;
{
const auto npart_send = npart();
std::vector<npart_t> glob_nparts(domains_total);
Expand Down Expand Up @@ -618,8 +623,11 @@ namespace ntt {
fmt::format("Writing particle checkpoint for species #%d", index()),
HERE);

npart_t npart_offset = 0u;
npart_t npart_total = npart();
// global totals/offsets are sums over all ranks and can exceed the
// per-rank `npart_t` (uint32_t) range at large problem sizes, so
// accumulate them in a 64-bit type
std::size_t npart_offset = 0u;
std::size_t npart_total = npart();

#if defined(MPI_ENABLED)
{
Expand Down
Loading