Drop environment variables from EPICS base that are too long#87
Open
simon-ess wants to merge 1 commit into
Open
Drop environment variables from EPICS base that are too long#87simon-ess wants to merge 1 commit into
simon-ess wants to merge 1 commit into
Conversation
This is configured in CONFIG_SITE(.local) using the variable `IOCSTATS_MAX_ENV_VAR_LENGTH`; the default is 40, but a given site should tune it for their own PV prefix needs.
Contributor
Author
|
"Fixes" the (closed) PR on EPICS base: epics-base/epics-base#885 |
lucmaga
reviewed
Jun 22, 2026
| if ($opt_l) { | ||
| $max_length = $opt_l; | ||
| } else { | ||
| $max_length = 15; |
Contributor
Author
There was a problem hiding this comment.
Quite right. It's also overriddent by a CONFIG_SITE variable anyhow...
lucmaga
reviewed
Jun 22, 2026
| print STDERR "Warning: Variable $_ is potentially too long for a "; | ||
| print STDERR "PV name given a typical prefix. Skipping.\n"; | ||
| next | ||
| } |
There was a problem hiding this comment.
IMHO a build failure would be better than having a truncated PV name by mistake. But this works also.
Contributor
Author
There was a problem hiding this comment.
The point here is that we skip anything that's too long, we don't truncate those PVs. This relates to the fact that there is a variable from EPICS base that is annoyingly long, see #86. So we should not fail, but warn and move on.
|
LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is configured in CONFIG_SITE(.local) using the variable
IOCSTATS_MAX_ENV_VAR_LENGTH; the default is 40, but a given site should tune it for their own PV prefix needs.Fixes #86.
@anjohnson my perl isn't particularly great, I wouldn't mind a review from you.