Dave/include columns - #281
Open
davethieben wants to merge 2 commits into
Open
Conversation
…nclude columns when generating SQL for an entity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently SimpleCrud only includes properties in SELECT/INSERT/UPDATE if the property type is a "simple" type (standard primitives like int, bool, string, etc) and is not marked as
[Editable(false)]. Custom types can not be used for properties in SimpleCrud models, even though it is supported in Dapper by using aTypeHandler<T>. Registering aTypeHandler<T>inDapper.SqlMapperenables Dapper to map to/from db values, but SimpleCrud doesn't know this and has no way of interogating Dapper for types that are handled this way.This PR updates
GetScaffoldableProperties<T>()to also include properties that have either the[Column]attribute or the[Key]attribute explicitly applied, or if the property type implementsIConvertible. This allows a consumer to indicate properties that are to be included in SQL statements either on the property itself or on the property type.To fully support using a property type that is
IConvertible, Dapper must be configured with aTypeHandler<T>to provide the mapping to/from the database expected values.Added tests to confirm.