build(deps): bump devcontainers/go from dev-1.25-bookworm to dev-1.26-bookworm in /tools/container-images/devcontainer

[dependabot]

Bumps devcontainers/go from dev-1.25-bookworm to dev-1.26-bookworm.

[k8s-ci-robot]

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[serathius]

cc @ivanvc

[ivanvc]

@serathius, this worked as expected. We wanted GitHub actions to bump the dev container JSON definition.

We decided to switch to the dev container based on tooling and quicker adoption of newer minors. Right, @henrybear327?

/ok-to-test
/cc @henrybear327

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.15%. Comparing base (d57b7bd) to head (29cb536).
⚠️ Report is 1 commits behind head on main.

⚠️ Current head 29cb536 differs from pull request most recent head f688b69

Please upload reports for the commit f688b69 to get more accurate results.

Additional details and impacted files

see 30 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #21752      +/-   ##
==========================================
- Coverage   70.27%   70.15%   -0.12%     
==========================================
  Files         426      426              
  Lines       35242    35242              
==========================================
- Hits        24765    24725      -40     
- Misses       9091     9130      +39     
- Partials     1386     1387       +1     

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e29c65f...f688b69. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[serathius]

@serathius, this worked as expected. We wanted GitHub actions to bump the dev container JSON definition.

Sounds good.

[serathius]

Do we have any tests for devcontainers to detect if bumping image will break it?

[henrybear327]

@serathius, this worked as expected. We wanted GitHub actions to bump the dev container JSON definition.

We decided to switch to the dev container based on tooling and quicker adoption of newer minors. Right, @henrybear327?

/ok-to-test /cc @henrybear327

Yes, this correct. Please see the links in comment #21752 (comment)

[henrybear327]

Do we have any tests for devcontainers to detect if bumping image will break it?

We are currently relying on the existing tests on CI for catching issues for now, unless I am missing something.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dependabot[bot], henrybear327, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [serathius]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[henrybear327]

/retest

[ivanvc]

We are currently relying on the existing tests on CI for catching issues for now, unless I am missing something.

But I don't think we're actually testing that the tests run on that specific image.

[ivanvc]

I guess we could add a CI job using the devcontainer as the base image (I'm thinking of a GitHub Action, since we could tie it to this update). What would be a good test? Trying to build the project? WDYT, @serathius?

[serathius]

I guess we could add a CI job using the devcontainer as the base image (I'm thinking of a GitHub Action, since we could tie it to this update). What would be a good test? Trying to build the project? WDYT, @serathius?

Make sense to me. Building etcd is the first thing we do when starting devcontainer, would be good to make sure it works :P

etcd/.devcontainer/devcontainer.json

Line 19 in d5527f2

"postCreateCommand": "make build"

[ivanvc]

Sounds good, thanks, @serathius. I'll push to this branch to see how the workflow would work on an actual pull request.

[ivanvc]

I lied, it's probably going to be better if we have it in a different pull request 😂

[ivanvc]

@dependabot recreate

[ivanvc]

🤕

! [remote rejected] HEAD -> dependabot/docker/tools/container-images/devcontainer/devcontainers/go-dev-1.26-bookworm (refusing to allow a GitHub App to create or update workflow .github/workflows/devcontainer-test.yml without workflows permission)

[ivanvc]

@dependabot recreate

[ivanvc]

Great, my idea is not going to work. We can't update a GitHub workflow within another workflow. Per copilot:

• Workflows cannot be created/modified by the GITHUB_TOKEN from within a workflow run, by design, even if you specify workflows: write (it will be ignored or error).
• Only a GitHub App or Personal Access Token (PAT) with workflow (note, singular) or broader scopes can commit changes to workflow files.
• If your workflow makes a commit to workflow files (in .github/workflows/), you must configure your automation to use a Personal Access Token (with workflow scope and admin access), or a GitHub App with the correct app installation token.

The solution is to use Docker in Docker using the new devcontainer. In this case, I believe we could use the Prow infrastructure instead of a GitHub Action. I'll briefly park this idea and revisit it after finishing other work on the Go workspace and release tasks for 3.7.

I'll draft this pull request and will remove the GitHub action I added.

[serathius]

I'll draft this pull request and will remove the GitHub action I added.

Thanks for driving this!