dependency: bump github.com/olekukonko/tablewriter from 0.0.5 to 1.1.4#21763
dependency: bump github.com/olekukonko/tablewriter from 0.0.5 to 1.1.4#21763Matovidlo wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Matovidlo The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @Matovidlo. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Backport of etcd-io#20008 to release-3.6. Mirrors @jachym-tousek-keboola's etcd-io#21675 with a complete bill of materials: in addition to github.com/olekukonko/{errors,ll}, this also adds the transitive dependencies github.com/clipperhouse/displaywidth, github.com/clipperhouse/uax29/v2/graphemes, and github.com/olekukonko/cat, and removes the no-longer-referenced github.com/rivo/uniseg. Verified locally with `make verify-bom` and `make verify-gofmt`, plus `go build ./...` in etcdctl/ and etcdutl/. Signed-off-by: Martin Vaško <Matovidlo2@gmail.com>
979e1b8 to
45b496b
Compare
|
thx for PR. Usually we don't backport feature request or just dependency bump unless there is any CVE. FYI. We will release etcd v3.7 soon. |
Backport of #20008 to
release-3.6. Same scope as @jachym-tousek-keboola's #21675, with the bill of materials updated to actually match the new module graph so thatmake verify-bompasses.Why a parallel PR
#21675 only adds
github.com/olekukonko/{errors,ll}tobill-of-materials.jsonand leavesgithub.com/rivo/unisegin. Its CI fails atverify-bomwith:The diff
license-bill-of-materialsreports against the committed BOM is:github.com/clipperhouse/displaywidth,github.com/clipperhouse/uax29/v2/graphemes,github.com/olekukonko/catgithub.com/rivo/unisegThis PR applies the same code/
go.{mod,sum}changes as #21675 and additionally fixes those four BOM entries.What changed
go.{mod,sum}(root,etcdctl/,etcdutl/,tests/):github.com/olekukonko/tablewriter0.0.5 → 1.1.4 and the new transitive dependency set.etcdctl/ctlv3/command/printer_table.go,etcdutl/etcdutl/printer_table.go: migrated to the 1.1.x table-builder API (tablewriter.NewTable+NewConfigBuilder().WithRowAlignment(tw.AlignRight),Header(...)).bill-of-materials.json: aligned with the new module graph (see above).Verification
Run locally on the resulting branch from
release-3.6:The dependency bump exists upstream because newer libraries we consume keep pulling
tablewriterforward; the fix is intablewriter1.x and isn't planned for a 3.6 etcd release otherwise. Same motivation as #21675.Refs: #20008, #21675