Skip to content

dependency: bump github.com/olekukonko/tablewriter from 0.0.5 to 1.1.4#21763

Open
Matovidlo wants to merge 1 commit into
etcd-io:release-3.6from
Matovidlo:martinvasko-tablewriter-bom-release-3-6
Open

dependency: bump github.com/olekukonko/tablewriter from 0.0.5 to 1.1.4#21763
Matovidlo wants to merge 1 commit into
etcd-io:release-3.6from
Matovidlo:martinvasko-tablewriter-bom-release-3-6

Conversation

@Matovidlo
Copy link
Copy Markdown

Backport of #20008 to release-3.6. Same scope as @jachym-tousek-keboola's #21675, with the bill of materials updated to actually match the new module graph so that make verify-bom passes.

Why a parallel PR

#21675 only adds github.com/olekukonko/{errors,ll} to bill-of-materials.json and leaves github.com/rivo/uniseg in. Its CI fails at verify-bom with:

modularized licenses do not match given bill of materials
FAIL: 'bom' FAILED

The diff license-bill-of-materials reports against the committed BOM is:

  • Missing (in graph but not in BOM): github.com/clipperhouse/displaywidth, github.com/clipperhouse/uax29/v2/graphemes, github.com/olekukonko/cat
  • Stale (in BOM but no longer in graph): github.com/rivo/uniseg

This PR applies the same code/go.{mod,sum} changes as #21675 and additionally fixes those four BOM entries.

What changed

  • go.{mod,sum} (root, etcdctl/, etcdutl/, tests/): github.com/olekukonko/tablewriter 0.0.5 → 1.1.4 and the new transitive dependency set.
  • etcdctl/ctlv3/command/printer_table.go, etcdutl/etcdutl/printer_table.go: migrated to the 1.1.x table-builder API (tablewriter.NewTable + NewConfigBuilder().WithRowAlignment(tw.AlignRight), Header(...)).
  • bill-of-materials.json: aligned with the new module graph (see above).

Verification

Run locally on the resulting branch from release-3.6:

make verify-bom    # PASS
make verify-gofmt  # PASS
(cd etcdctl && go build ./...)  # OK
(cd etcdutl && go build ./...)  # OK
etcdctl version    # 3.6.11

The dependency bump exists upstream because newer libraries we consume keep pulling tablewriter forward; the fix is in tablewriter 1.x and isn't planned for a 3.6 etcd release otherwise. Same motivation as #21675.

Refs: #20008, #21675

@k8s-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Matovidlo
Once this PR has been reviewed and has the lgtm label, please assign wenjiaswe for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Copy Markdown

Hi @Matovidlo. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Backport of etcd-io#20008 to release-3.6. Mirrors @jachym-tousek-keboola's
etcd-io#21675 with a complete bill of materials: in addition to
github.com/olekukonko/{errors,ll}, this also adds the transitive
dependencies github.com/clipperhouse/displaywidth,
github.com/clipperhouse/uax29/v2/graphemes, and github.com/olekukonko/cat,
and removes the no-longer-referenced github.com/rivo/uniseg.

Verified locally with `make verify-bom` and `make verify-gofmt`, plus
`go build ./...` in etcdctl/ and etcdutl/.

Signed-off-by: Martin Vaško <Matovidlo2@gmail.com>
@Matovidlo Matovidlo force-pushed the martinvasko-tablewriter-bom-release-3-6 branch from 979e1b8 to 45b496b Compare May 19, 2026 09:01
@ahrtr
Copy link
Copy Markdown
Member

ahrtr commented May 19, 2026

thx for PR. Usually we don't backport feature request or just dependency bump unless there is any CVE.

FYI. We will release etcd v3.7 soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants