Skip to content

add test for leak of file lock#21779

Open
silentred wants to merge 1 commit into
etcd-io:mainfrom
silentred:test-filelock-leak
Open

add test for leak of file lock#21779
silentred wants to merge 1 commit into
etcd-io:mainfrom
silentred:test-filelock-leak

Conversation

@silentred
Copy link
Copy Markdown
Contributor

This PR should pass tests after #21766 is merged.

Signed-off-by: shenmu.wy <shenmu.wy@antfin.com>
@k8s-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: silentred
Once this PR has been reviewed and has the lgtm label, please assign fuweid for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius
Copy link
Copy Markdown
Member

Thanks, this really helps!

@k8s-ci-robot
Copy link
Copy Markdown

@silentred: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-unit-test-arm64 1d4e138 link true /test pull-etcd-unit-test-arm64
pull-etcd-unit-test-386 1d4e138 link true /test pull-etcd-unit-test-386
pull-etcd-unit-test-amd64 1d4e138 link true /test pull-etcd-unit-test-amd64
pull-etcd-coverage-report 1d4e138 link true /test pull-etcd-coverage-report

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.21%. Comparing base (e7ca1c0) to head (1d4e138).
⚠️ Report is 24 commits behind head on main.

Additional details and impacted files

see 24 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #21779      +/-   ##
==========================================
+ Coverage   70.15%   70.21%   +0.06%     
==========================================
  Files         426      426              
  Lines       35242    35242              
==========================================
+ Hits        24723    24745      +22     
+ Misses       9125     9108      -17     
+ Partials     1394     1389       -5     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7ca1c0...1d4e138. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants