Skip to content

scripts/container_scan.sh: add container image CVE scanning#21795

Open
kairosci wants to merge 1 commit into
etcd-io:mainfrom
kairosci:fix/cve-scan-workflow
Open

scripts/container_scan.sh: add container image CVE scanning#21795
kairosci wants to merge 1 commit into
etcd-io:mainfrom
kairosci:fix/cve-scan-workflow

Conversation

@kairosci
Copy link
Copy Markdown
Contributor

@kairosci kairosci commented May 23, 2026

Add a script, Makefile target, and CI workflow to scan the container base image with Trivy for OS-level CVEs. etcd is built with CGO_ENABLED=0 and the existing govulncheck+CodeQL pipeline only covers Go vulnerabilities, so OS-level CVEs in the distroless base image were not detected. Closes #21252

@k8s-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kairosci
Once this PR has been reviewed and has the lgtm label, please assign spzala for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added github_actions Pull requests that update GitHub Actions code needs-ok-to-test labels May 23, 2026
@k8s-ci-robot
Copy link
Copy Markdown

Hi @kairosci. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: Alessio Attilio <attilio.alessio@protonmail.com>
@kairosci kairosci force-pushed the fix/cve-scan-workflow branch from e856166 to af39ce4 Compare May 23, 2026 10:47
@kairosci
Copy link
Copy Markdown
Contributor Author

cc @ahrtr @ivanvc

@ahrtr ahrtr requested review from ArkaSaha30 and ivanvc May 23, 2026 12:49
@ahrtr
Copy link
Copy Markdown
Member

ahrtr commented May 23, 2026

@ArkaSaha30 @ivanvc I believe we already have such CVE scan against container image, correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code needs-ok-to-test size/M

Development

Successfully merging this pull request may close these issues.

Review the CVE scan workflow

3 participants