ci(github): strip ANSI colour codes from the environment diff comment#10
Merged
Merged
Conversation
nix store diff-closures colours the size delta even when stdout is not a TTY, so the colour escape codes leaked into the PR comment and rendered as raw control codes (e.g. ^[[31;1m93.9 KiB^[[0m). Pipe the diff through sed to strip the SGR codes before it reaches the comment body.
jcardozo-eth
force-pushed
the
ci/strip-ansi-from-environment-diff-comment
branch
from
July 15, 2026 17:34
076ff37 to
bb77c56
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #9, found while verifying on PR #5.
nix store diff-closurescolours the size delta even when stdout is not a TTY, so the colour escape codes leaked into the comment and rendered as raw control codes (e.g.^[[31;1m93.9 KiB^[[0m). Strip them withsedbefore the diff reaches the comment body.Checklist
just checkgreen