Skip to content

Enable with syntax using the new MetopReader.dataset method.#17

Merged
lupemba merged 1 commit into
mainfrom
feat-implement-with-syntax
Feb 9, 2026
Merged

Enable with syntax using the new MetopReader.dataset method.#17
lupemba merged 1 commit into
mainfrom
feat-implement-with-syntax

Conversation

@lupemba

@lupemba lupemba commented Dec 4, 2025

Copy link
Copy Markdown
Member
  • Add MetopReader.dataset method to enable using the with syntax
  • Add an test for the with syntax
  • Add an example to the readme
  • Bump the version to 0.1.1 to prepare for next release.

@lupemba lupemba requested a review from pacospace December 4, 2025 13:43
@lupemba

lupemba commented Dec 4, 2025

Copy link
Copy Markdown
Member Author

Solve issue #5

@pacospace pacospace left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the delay, one comment otherwise LGTM

Comment thread metoppy/__init__.py

# Optional: version info
__version__ = "0.1.0"
__version__ = "0.1.1"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

according to standard https://semver.org/ this should be 0.2.0 if we are introducing new funcionality.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have to do it like that since we are still in version 0.y.z

  1. Major version zero (0.y.z) is for initial development. Anything MAY change at any time. The public API SHOULD NOT be considered stable.

The julia package manager uses a slightly different approach to 0.y.z versions where z is incremented for non-breaking changes and y is incremented for breaking changes.
https://pkgdocs.julialang.org/v1/compatibility/#compat-pre-1.0

So if you think 0.2.0 is more pythonic then I will change it but we don't have to do it according to semver.

Comment thread pyproject.toml
[project]
name = "metoppy"
version = "0.1.0"
version = "0.1.1"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

according to standard https://semver.org/ this should be 0.2.0 if we are introducing new functionality.

@pacospace pacospace self-requested a review December 9, 2025 15:30

@pacospace pacospace left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lupemba lupemba merged commit acb2a3a into main Feb 9, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants