chore: bump ev-node in apps#3346
Conversation
|
Warning Review limit reached
More reviews will be available in 6 minutes and 8 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (6)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Claude finished @julienrbrt's task in 1m 32s —— View job PR Review: chore: bump ev-node in apps
SummaryThis PR bumps The changes are mechanically correct and the go.sum hashes are consistent. A few observations: Observations1. Commented-out replace directives — unconventional style
// replace (
// github.com/evstack/ev-node => ../../
// ...
// )Go tooling ignores comments, so this is functionally correct — but it's non-standard. The convention is to simply delete 2. test/e2e still uses active replace directives — intentional and correct
3. test/e2e references a pseudo-version for execution/evm This is overridden by the 4. Scope of indirect dependency bumps in execution/evm The 5. execution/grpc v1.0.0 stable release — no code review needed here The VerdictNo blocking issues. The PR is functionally correct. The main suggestion is to remove the commented-out |
|
The latest Buf updates on your PR. Results from workflow CI / buf-check (pull_request).
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3346 +/- ##
=======================================
Coverage 60.70% 60.70%
=======================================
Files 127 127
Lines 13781 13781
=======================================
Hits 8366 8366
Misses 4502 4502
Partials 913 913
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Overview
Follow-up of #3345