Skip to content

Android: Add new configuration for DevSupportManager#53557

Closed
coado wants to merge 1 commit into
facebook:mainfrom
coado:dev-menu-android
Closed

Android: Add new configuration for DevSupportManager#53557
coado wants to merge 1 commit into
facebook:mainfrom
coado:dev-menu-android

Conversation

@coado
Copy link
Copy Markdown
Contributor

@coado coado commented Sep 2, 2025 •
edited
Loading

Summary:

Following the RFC, this PR adds new DevMenuConfiguration object and extends ReactHost API for passing settings to the particular DevSupportManager. The DevMenuConfiguration includes:

  • isDevMenuEnabled,
  • isShakeGestureEnabled,
  • areKeyboardShortcutsEnabled,

Changelog:

[ANDROID][ADDED] - Add new configuration for RCTDevMenu

Test Plan:

Tested with different configuration on DevMenuConfiguration:

Click to view code 
override fun onCreate(savedInstanceState: Bundle?) {
    super.onCreate(savedInstanceState)

    fullyDrawnReporter.addReporter()
    maybeUpdateBackgroundColor()

    reactDelegate?.reactHost?.let { reactHost ->
      val devMenuConfiguration = DevMenuConfiguration(
        isDevMenuEnabled = true,
        isShakeGestureEnabled = false,
        areKeyboardShortcutsEnabled = false,
      )
      reactHost.setDevMenuConfiguration(devMenuConfiguration)
    }

    // register insets listener to update margins on the ReactRootView to avoid overlap w/ system
    // bars
    reactDelegate?.reactRootView?.let { rootView ->
      val insetsType: Int =
          WindowInsetsCompat.Type.systemBars() or WindowInsetsCompat.Type.displayCutout()

      val windowInsetsListener = { view: View, windowInsets: WindowInsetsCompat ->
        val insets = windowInsets.getInsets(insetsType)

        (view.layoutParams as FrameLayout.LayoutParams).apply {
          setMargins(insets.left, insets.top, insets.right, insets.bottom)
        }

        WindowInsetsCompat.CONSUMED
      }
      ViewCompat.setOnApplyWindowInsetsListener(rootView, windowInsetsListener)
    }
  }

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 2, 2025
@facebook-github-bot facebook-github-bot added p: Software Mansion Partner: Software Mansion Partner p: Facebook Partner: Facebook labels Sep 2, 2025
j-piasecki
j-piasecki reviewed Sep 3, 2025
View reviewed changes
Comment thread ...eact-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/DevMenuConfiguration.kt Outdated
Comment thread ...act-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/DevSupportManagerBase.kt Outdated
Comment thread ...act-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/DevSupportManagerBase.kt Outdated
Comment thread ...act-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/DevSupportManagerBase.kt Outdated
Comment thread packages/rn-tester/android/app/src/main/java/com/facebook/react/uiapp/RNTesterActivity.kt
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Sep 4, 2025

@coado has imported this pull request. If you are a Meta employee, you can view this in D81684310.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Sep 4, 2025

@coado has imported this pull request. If you are a Meta employee, you can view this in D81684310.

@coado coado marked this pull request as ready for review September 4, 2025 15:09
cortinico
cortinico requested changes Sep 8, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Sep 11, 2025

This pull request was exported from Phabricator. Differential Revision: D81684310

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Sep 15, 2025

@coado has imported this pull request. If you are a Meta employee, you can view this in D81684310.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Sep 15, 2025

@coado has exported this pull request. If you are a Meta employee, you can view the originating diff in D81684310.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Sep 15, 2025

@coado has exported this pull request. If you are a Meta employee, you can view the originating diff in D81684310.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Sep 17, 2025

@coado has exported this pull request. If you are a Meta employee, you can view the originating diff in D81684310.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Sep 24, 2025

@coado has exported this pull request. If you are a Meta employee, you can view the originating diff in D81684310.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Sep 29, 2025

@coado has exported this pull request. If you are a Meta employee, you can view the originating diff in D81684310.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Sep 29, 2025

@coado has exported this pull request. If you are a Meta employee, you can view the originating diff in D81684310.

@coado coado force-pushed the dev-menu-android branch from 417830c to f0b6713 Compare October 1, 2025 09:03
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Oct 1, 2025

@coado has exported this pull request. If you are a Meta employee, you can view the originating Diff in D81684310.

@coado coado force-pushed the dev-menu-android branch from f0b6713 to c25c1bd Compare October 6, 2025 15:50
@meta-codesync
Copy link
Copy Markdown

meta-codesync Bot commented Oct 6, 2025

@coado has exported this pull request. If you are a Meta employee, you can view the originating Diff in D81684310.

cortinico
cortinico approved these changes Oct 17, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

@coado @facebook-github-bot
Android: Add new configuration for DevSupportManager (facebook#53557)
b92451e 
Summary:
Following the [RFC](react-native-community/discussions-and-proposals#925), this PR adds new `DevMenuConfiguration` object and extends `ReactHost` API for passing settings to the particular `DevSupportManager`.  The `DevMenuConfiguration` includes:

- isDevMenuEnabled,
- isShakeGestureEnabled,
- areKeyboardShortcutsEnabled,

## Changelog:

[ANDROID][ADDED] - Add new configuration for `RCTDevMenu`


Test Plan:
Tested with different configuration on `DevMenuConfiguration`:

<details>
<summary>Click to view code</summary>

```kt
override fun onCreate(savedInstanceState: Bundle?) {
    super.onCreate(savedInstanceState)

    fullyDrawnReporter.addReporter()
    maybeUpdateBackgroundColor()

    reactDelegate?.reactHost?.let { reactHost ->
      val devMenuConfiguration = DevMenuConfiguration(
        isDevMenuEnabled = true,
        isShakeGestureEnabled = false,
        areKeyboardShortcutsEnabled = false,
      )
      reactHost.setDevMenuConfiguration(devMenuConfiguration)
    }

    // register insets listener to update margins on the ReactRootView to avoid overlap w/ system
    // bars
    reactDelegate?.reactRootView?.let { rootView ->
      val insetsType: Int =
          WindowInsetsCompat.Type.systemBars() or WindowInsetsCompat.Type.displayCutout()

      val windowInsetsListener = { view: View, windowInsets: WindowInsetsCompat ->
        val insets = windowInsets.getInsets(insetsType)

        (view.layoutParams as FrameLayout.LayoutParams).apply {
          setMargins(insets.left, insets.top, insets.right, insets.bottom)
        }

        WindowInsetsCompat.CONSUMED
      }
      ViewCompat.setOnApplyWindowInsetsListener(rootView, windowInsetsListener)
    }
  }
```

</details>

Reviewed By: cortinico

Differential Revision: D81684310

Pulled By: coado
@meta-codesync meta-codesync Bot closed this in 4ddf2ce Oct 21, 2025
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Oct 21, 2025
@meta-codesync
Copy link
Copy Markdown

meta-codesync Bot commented Oct 21, 2025

@coado merged this pull request in 4ddf2ce.

@react-native-bot
Copy link
Copy Markdown
Collaborator

react-native-bot commented Oct 21, 2025

This pull request was successfully merged by @coado in 4ddf2ce

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@j-piasecki j-piasecki j-piasecki left review comments

@cortinico cortinico cortinico approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. meta-exported p: Facebook Partner: Facebook p: Software Mansion Partner: Software Mansion Partner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@coado @facebook-github-bot @react-native-bot @cortinico @j-piasecki