[19.0.x] Enable CI#36555
Merged
Merged
Conversation
github-actions
Bot
added
the
React Core Team
Published artifacts are fine which is confirmed by passing build tests. Only tests from source were failing.
eps1lon
commented
May 27, 2026
Comment on lines
-6
to
-8
| "devEngines": { | ||
| "node": "20.x || 22.x" | ||
| }, |
Collaborator
Author
There was a problem hiding this comment.
Fixes
npm error Invalid property "devEngines.node"
-- https://github.com/facebook/react/actions/runs/26532862835/job/78154784664?pr=36555#step:8:13
main got this change in #32398
Can't be handled by older npm versions
eps1lon
commented
May 27, 2026
| // at runtime. We should instead inject the version number as part of the build | ||
| // process, and use the ReactVersions.js module as the single source of truth. | ||
| export default '19.0.1'; | ||
| export default '19.0.6'; |
Collaborator
Author
There was a problem hiding this comment.
Published artifacts are fine (i.e. already use 19.0.6) which is confirmed by passing build tests.
Only tests from source were failing.
hoxyq
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...and fix it.
Backports #36551, #35634, and #32070.