PDF report customization#982
Open
babo989 wants to merge 2 commits into
Open
Conversation
sonnyp
reviewed
Jul 15, 2026
sonnyp
left a comment
sonnyp
left a comment
Collaborator
There was a problem hiding this comment.
Add justfile
Make the root justfile run the justfile of reporter
Use uv and pyprojects for dependencies
Remove requirements.txt
Look at "segmenter" or "controller" for inspiration.
So that reporter is setup with the rest of the system and user doesn't need to figure out the commands to run
Also add a README.md - similar to segmenter/README.md - with the API documented.
Comment on lines
+10
to
+11
| # Dedicated reporter venv (created with: uv venv /opt/PlanktoScope/reporter/.venv). | ||
| ExecStart=/opt/PlanktoScope/reporter/.venv/bin/python /opt/PlanktoScope/reporter/report_generator.py |
Collaborator
There was a problem hiding this comment.
ExecStart=/usr/local/bin/uv run main.py
sonnyp
reviewed
Jul 15, 2026
| from pathlib import Path | ||
|
|
||
| import numpy as np | ||
| import paho.mqtt.client as mqtt |
Collaborator
There was a problem hiding this comment.
Please use aiomqtt
asyncio for the win
You can get inspiration from bubbler/main.py for how to use.
- Add pyproject.toml and uv.lock, and remove requirements.txt (modeled on segmenter/) - Add reporter/justfile for setup/testing and wire it into the root justfile - Add reporter/README.md documenting the MQTT API payload shapes and responses - Rename report_generator.py to main.py and update planktoscope-org.reporter.service - Rewrite MQTT layer using aiomqtt/asyncio, running PDF rendering in asyncio.to_thread - Verify on-device execution, service startup, and full MQTT round-trip PDF generation Thanks @sonnyp — all addressed in this push.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added customization popup. Worked on aesthetics of the report @jeremyszym