Normalize long trailing decimal zero suffixes - #403
Open
perfloop-agent wants to merge 1 commit into
Open
Conversation
Keep proof on the public from_chars path. Remove the direct digit_comp benchmark because no current claim or check uses it. Reviewed-by: Bentley Reviewed-by: Thompson
tsenart
force-pushed
the
perfloop-pr-open-dz12ma0n75
branch
from
August 11, 2026 23:34
52a1f4f to
b2c714a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Long ambiguous decimals can reach the bigint comparison fallback. That path materialized trailing decimal zeros even though they add no information.
This change:
All-zero coefficients remain unchanged. Integer zeros are trimmed only after an all-zero fraction. Public result bits, consumed pointers, and error codes stay identical.
Performance
All measurements use the public
fast_float::from_chars<double>path.A later repeat of the exact zero-bound 0-15 measurement was statistically undecidable because its interval crossed zero. It did not show a material regression. The production headers are unchanged from the accepted result, and an independent cross-build kept the public-path gains when benchmark layout was held constant.
Testing
charinputs, 6,208 wide-character inputs, and 25,002 float/double inputs.from_charsmodes and route verification. It has no direct internal-target benchmark.Full verification record: https://app.perfloop.ai/t/oss/cases/case_xwm9h4yejp